Skip to content

bpo-20547: Use specific asserts in bigmem tests #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 1 commit into from
Closed

bpo-20547: Use specific asserts in bigmem tests #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Lib/test/test_bigmem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ def test_hash(self, size):
h1 = hash(t1)
del t1
t2 = (0,) * (size + 1)
self.assertFalse(h1 == hash(t2))
self.assertNotEqual(h1, hash(t2))

@bigmemtest(size=_2G + 10, memuse=8)
def test_index_and_slice(self, size):
Expand Down Expand Up @@ -991,8 +991,8 @@ def basic_test_inplace_concat(self, size):
l = [sys.stdout] * size
l += l
self.assertEqual(len(l), size * 2)
self.assertTrue(l[0] is l[-1])
self.assertTrue(l[size - 1] is l[size + 1])
self.assertIs(l[0], l[-1])
self.assertIs(l[size - 1], l[size + 1])

@bigmemtest(size=_2G // 2 + 2, memuse=24)
def test_inplace_concat_small(self, size):
Expand Down Expand Up @@ -1091,13 +1091,13 @@ def basic_test_inplace_repeat(self, size):
l = ['']
l *= size
self.assertEqual(len(l), size)
self.assertTrue(l[0] is l[-1])
self.assertIs(l[0], l[-1])
del l

l = [''] * size
l *= 2
self.assertEqual(len(l), size * 2)
self.assertTrue(l[size - 1] is l[-1])
self.assertIs(l[size - 1], l[-1])

@bigmemtest(size=_2G // 2 + 2, memuse=16)
def test_inplace_repeat_small(self, size):
Expand Down Expand Up @@ -1131,8 +1131,8 @@ def test_append(self, size):
l = [object()] * size
l.append(object())
self.assertEqual(len(l), size+1)
self.assertTrue(l[-3] is l[-2])
self.assertFalse(l[-2] is l[-1])
self.assertIs(l[-3], l[-2])
self.assertIsNot(l[-2], l[-1])

@bigmemtest(size=_2G // 5 + 2, memuse=8 * 5)
def test_count(self, size):
Expand All @@ -1144,8 +1144,8 @@ def basic_test_extend(self, size):
l = [object] * size
l.extend(l)
self.assertEqual(len(l), size * 2)
self.assertTrue(l[0] is l[-1])
self.assertTrue(l[size - 1] is l[size + 1])
self.assertIs(l[0], l[-1])
self.assertIs(l[size - 1], l[size + 1])

@bigmemtest(size=_2G // 2 + 2, memuse=16)
def test_extend_small(self, size):
Expand Down