Skip to content

bpo-33876: Mention relevant pythonesque implementations - #7741

Closed
andresdelfino wants to merge 4 commits into
python:masterfrom
andresdelfino:mention-micropython
Closed

bpo-33876: Mention relevant pythonesque implementations#7741
andresdelfino wants to merge 4 commits into
python:masterfrom
andresdelfino:mention-micropython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Jun 16, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@willingc

willingc commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

Hi @andresdelfino, Thanks. If we are mentioning MicroPython, we should also mention CircuitPython as well.

willingc
willingc reviewed Jun 16, 2018
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's add CircuitPython too.

@andresdelfino

andresdelfino commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

CircuitPython added! I believe I have highlighted the main differences right. Wasn't sure about the URL, but https://learn.adafruit.com/welcome-to-circuitpython/what-is-circuitpython looked somewhat weird. The GitHub repository seemed better.

willingc
willingc approved these changes Jun 16, 2018
View reviewed changes
Comment thread Doc/reference/introduction.rst Outdated

CircuitPython
A MicroPython fork targeted towards students and beginners, with a strong
focus on Adafruit boards. For more information, see `the CircuitPython

@willingc willingc Jun 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andresdelfino. All of Adafruit's boards are open-hardware which would be good to mention. Perhaps "...on Adafruit's open-hardware boards.

@andresdelfino andresdelfino Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

willingc
willingc approved these changes Jun 16, 2018
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andresdelfino. I'll leave this open for another day for others to comment, but this looks good to me. Thanks for the helpful docs work that you are doing 👍

@andresdelfino

andresdelfino commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Please do not merge, see issue.

@andresdelfino andresdelfino changed the title bpo-33876: Mention the MicroPython implementation in Introduction bpo-33876: Mention relevant pythonesque implementations Jun 18, 2018
@Mariatta

Mariatta commented Jun 22, 2018

Copy link
Copy Markdown
Member

Thanks for the PR, but as I mentioned in bpo, I just don't think this list is needed in our documentation.

@Mariatta Mariatta closed this Jun 22, 2018
@andresdelfino andresdelfino mentioned this pull request Jun 25, 2018
Closed
@andresdelfino
andresdelfino deleted the mention-micropython branch June 25, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresdelfino @willingc @Mariatta @the-knights-who-say-ni @bedevere-bot