Skip to content

bpo-31299: filter_frames argument for traceback functions#5210

Closed
vaultah wants to merge 2 commits into
python:masterfrom
vaultah:traceback-filter-argument
Closed

bpo-31299: filter_frames argument for traceback functions#5210
vaultah wants to merge 2 commits into
python:masterfrom
vaultah:traceback-filter-argument

Conversation

@vaultah
Copy link
Copy Markdown

@vaultah vaultah commented Jan 16, 2018

This is a more general and simplified version of #3231. Here the filtering argument is a callable (following the suggestion by Antoine Pitrou).

https://bugs.python.org/issue31299

@vaultah
Copy link
Copy Markdown
Author

vaultah commented Jan 16, 2018

My comment from the older PR is still relevant:

Considering the current number of positional arguments that the traceback functions accept, I feel that users should pass optional arguments by their names anyway... Addition of yet another optional argument to several traceback functions seems a good justification for breaking backwards compatibility and making the majority of optional arguments in that module keyword-only. What do you think?

@vaultah vaultah closed this Jan 17, 2018
@vaultah vaultah reopened this Jan 17, 2018
@vaultah
Copy link
Copy Markdown
Author

vaultah commented Jan 17, 2018

Travis-CI was having some problems, so I triggered a new build and it succeeded: https://travis-ci.org/python/cpython/builds/329887241

@vaultah vaultah closed this May 18, 2018
@vaultah vaultah reopened this May 18, 2018
@vaultah vaultah closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants