bpo-31860: Make the font sample in the IDLE font configuration dialog editable.#4106
Merged
terryjreedy merged 5 commits intoOct 28, 2017
Merged
Conversation
serhiy-storchaka
added
needs backport to 3.6
type-feature
terryjreedy
force-pushed
the
idle-editable-font-sample
branch
from
3415ac4 to
1b80bb6
Compare
Member
|
/about/across/ |
Edit code by increasing height to try to force Apveyor to run
terryjreedy
approved these changes
Oct 27, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Assuming tests pass and you do not object, I plan to merge this tomorrow.
Member
Author
|
LGTM. |
Contributor
|
Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2017
… editable. (pythonGH-4106) Changes persist while IDLE remains open (cherry picked from commit ed6554c)
|
GH-4154 is a backport of this pull request to the 3.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31860