Skip to content

bpo-31299: Implementation of ignore_modules argument for traceback functions#3231

Closed
vaultah wants to merge 3 commits into
python:masterfrom
vaultah:master
Closed

bpo-31299: Implementation of ignore_modules argument for traceback functions#3231
vaultah wants to merge 3 commits into
python:masterfrom
vaultah:master

Conversation

@vaultah
Copy link
Copy Markdown

@vaultah vaultah commented Aug 29, 2017

@vaultah
Copy link
Copy Markdown
Author

vaultah commented Aug 29, 2017

I noticed that MiscTest.test_all in test_traceback.py can be implemented using the new test.support.check__all__. Would it be okay to change it in this pull request?

@mscuthbert
Copy link
Copy Markdown

should ignore_modules go after chain for backwards compatibility? Possibly making it a keyword-only option?

@vaultah
Copy link
Copy Markdown
Author

vaultah commented Oct 1, 2017

While placing optional boolean arguments after non-boolean ones feels more natural to me, I didn't think about backwards compatibility, so that was an oversight.

That being said, considering the current number of positional arguments that the traceback functions accept, I feel that users should pass optional arguments by their names anyway... Addition of yet another optional argument to several traceback functions seems a good justification for breaking backwards compatibility and making the majority of optional arguments in that module keyword-only. What do you think?

@mscuthbert
Copy link
Copy Markdown

Yes I think that most of them should become keyword only would be the best, then order doesn't matter.

(In the throes of porting some Python code to JavaScript and not having keyword arguments is killing me. :-) so anything to encourage them I like )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants