Skip to content

bpo-44752: refactor part of rlcompleter.Completer.attr_matches - #27433

Merged
ambv merged 2 commits into
python:mainfrom
jdevries3133:bpo-44752-refactor-rcompleter
Jul 29, 2021
Merged

ambv merged 2 commits into
python:mainfrom
jdevries3133:bpo-44752-refactor-rcompleter

Conversation

@jdevries3133

@jdevries3133 jdevries3133 commented Jul 28, 2021 •

Copy link
Copy Markdown
Contributor

See the discussion about this change here:

#27401 (comment)

https://bugs.python.org/issue44752

@ambv

ambv commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

This will require resolving the conflict with the currently landed GH-27401, @jdevries3133.

@jdevries3133

Copy link
Copy Markdown
Contributor Author

@ambv merged!

@ambv

ambv commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

The ASAN failure is a re-run timeout.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

Copy link
Copy Markdown

GH-27446 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-27447 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2021
ambv pushed a commit that referenced this pull request Jul 29, 2021
ambv pushed a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants