bpo-42247: fix unittest.assertRaises bug where traceback entries were…#23687
Closed
iritkatriel wants to merge 1 commit into
Closed
bpo-42247: fix unittest.assertRaises bug where traceback entries were…#23687iritkatriel wants to merge 1 commit into
iritkatriel wants to merge 1 commit into
Conversation
… dropped from the chained exception
iritkatriel
changed the title
Member
Author
|
sorry about the noise - I need to fix the branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… dropped from the chained exception
Unittest applies a hack that uses the limit parameter of TracebackException to hide traceback frames from the unittest code itself. The problem with this is that the limit applies to the chained (context) exception too, so we lose frames we want to keep.
This patch replaces the hack by code that modifies the traceback to remove the frames we don't want.
https://bugs.python.org/issue42247