bpo-30495: IDLE: refactor textview#2283
Merged
Merged
Conversation
bpo-30495: IDLE: refactor textview bpo-30495: IDLE: refactor textview bpo-30495: IDLE: refactor textview bpo-30495: IDLE: refactor textview
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @louisom and @kbkaiser to be potential reviewers. |
terryjreedy
requested changes
Jun 29, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I said, "lets try TextviewWindow and TextviewFrame." Having tried them, I don't like them. ViewWindow is enough. Also, TextviewFrame should be split into a ViewFrame containing a TextFrame.
The close button should be in ViewFrame. It is currently redundant but will be needed if a Viewframe is tiled in a window, as Mark proposed for About IDLE.
I will give these a try.
terryjreedy
approved these changes
Jun 29, 2017
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 29, 2017
…more tests. (pythonGH-2283) Split TextViewer class into ViewWindow, ViewFrame, and TextFrame classes so that instances of the latter two can be placed with other widgets within a multiframe window. Patch by Cheryl Sabella. (cherry picked from commit 42bc8be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TextviewFrame class to separate frame from window.