bpo-41006: importlib.util no longer imports typing#20938
Merged
vstinner merged 1 commit intopython:masterfrom Jun 17, 2020
vstinner:importlib_typing
Merged
bpo-41006: importlib.util no longer imports typing#20938vstinner merged 1 commit intopython:masterfrom vstinner:importlib_typing
vstinner merged 1 commit intopython:masterfrom
vstinner:importlib_typing
Conversation
Create importlib._abc submodule to avoid importing typing when importlib.util is imported. Move Loader ABC into importlib._abc.
Member
Author
|
Another approach would be to move Traversable and TraversableReader classes to importlib.readers, but it seems like importlib.readers is not documented. I chose to write a PR which doesn't affect the importlib API. The cc @jaraco |
Member
Author
|
3 hours later, no Travis CI build was created. I close/reopen my PR to force Travis CI to schedule a new build. |
brettcannon
approved these changes
Jun 17, 2020
Member
Author
|
Thanks for the review @brettcannon! |
Dark-Feather
pushed a commit
to Dark-Feather/bitbot
that referenced
this pull request
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create importlib._abc submodule to avoid importing typing when
importlib.util is imported. Move Loader ABC into importlib._abc.
https://bugs.python.org/issue41006