bpo-37616: Handle version info more gracefully in getpath.c#20214
bpo-37616: Handle version info more gracefully in getpath.c#20214pablogsal merged 3 commits intopython:masterfrom
Conversation
|
From the C99 standard:
|
|
@serhiy-storchaka Does it occur to you if there is a simpler way to produce this string at compile time? |
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
If this change breaks IRIX support, we can reconsider IRIX support later ;-)
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4211927 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Seems that the almost all buildbot workers are green and the ones that fail are because some other unrelated issues (no space left on device and some PGO/LTO failures elsewhere). So I am going ahead and merge this |
|
CC: @ambv |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
@pablogsal: I don't think that we need a backport to 3.9 which only uses a single digit for the minor version. |
Makes sense, I just wanted to extend the progress 😅 |
https://bugs.python.org/issue37616