Skip to content

bpo-40010: COMPUTE_EVAL_BREAKER() checks for subinterpreter#19087

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:eval_break_subinterp
Mar 20, 2020
Merged

bpo-40010: COMPUTE_EVAL_BREAKER() checks for subinterpreter#19087
vstinner merged 1 commit intopython:masterfrom
vstinner:eval_break_subinterp

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 20, 2020 •
edited
Loading

COMPUTE_EVAL_BREAKER() now also checks if the Python thread state
belongs to the main interpreter. Don't break the evaluation loop if
there are pending signals but the Python thread state it belongs to a
subinterpeter.

  • Add _Py_IsMainThread() function.
  • Add _Py_ThreadCanHandleSignals() function.

https://bugs.python.org/issue40010

@vstinner
bpo-40010: COMPUTE_EVAL_BREAKER() checks for subinterpreter
426bd18 
COMPUTE_EVAL_BREAKER() now also checks if the Python thread state
belongs to the main interpreter. Don't break the evaluation loop if
there are pending signals but the Python thread state it belongs to a
subinterpeter.

* Add _Py_IsMainThread() function.
* Add _Py_ThreadCanHandleSignals() function.
@vstinner vstinner merged commit d2a8e5b into python:master Mar 20, 2020
@vstinner vstinner deleted the eval_break_subinterp branch March 20, 2020 12:39
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.x has failed when building commit d2a8e5b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/89/builds/473) and take a look at the build logs.
  4. Check if the failure is related to this commit (d2a8e5b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/89/builds/473

Failed tests:

  • test_smtplib

Failed subtests:

  • test_with_statement - test.test_smtplib.SMTPSimTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_mailbox: 9 min 29 sec
  • test_shelve: 6 min 29 sec
  • test_io: 2 min 56 sec
  • test_concurrent_futures: 2 min 52 sec
  • test_multiprocessing_spawn: 2 min 21 sec
  • test_largefile: 2 min 1 sec
  • test_unparse: 1 min 43 sec
  • test_capi: 1 min 38 sec
  • test_dbm: 1 min 38 sec
  • test_tokenize: 1 min 36 sec

1 test failed:
test_smtplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_smtplib

Total duration: 11 min 14 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/test_smtplib.py", line 1117, in test_with_statement
    code, message = smtp.noop()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 518, in noop
    return self.docmd("noop")
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 425, in docmd
    return self.getreply()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/smtplib.py", line 398, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable 3.x has failed when building commit d2a8e5b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/41/builds/478) and take a look at the build logs.
  4. Check if the failure is related to this commit (d2a8e5b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/41/builds/478

Failed tests:

  • test_smtplib

Failed subtests:

  • test_with_statement_QUIT_failure - test.test_smtplib.SMTPSimTests
  • test_with_statement - test.test_smtplib.SMTPSimTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_shelve: 5 min 49 sec
  • test_mailbox: 5 min 10 sec
  • test_sqlite: 3 min 4 sec
  • test_concurrent_futures: 2 min 51 sec
  • test_nntplib: 2 min 27 sec
  • test_multiprocessing_spawn: 2 min 23 sec
  • test_multiprocessing_forkserver: 2 min
  • test_gzip: 1 min 53 sec
  • test_capi: 1 min 37 sec
  • test_smtplib: 1 min 32 sec

1 test failed:
test_smtplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_smtplib

Total duration: 11 min 27 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/test_smtplib.py", line 1117, in test_with_statement
    code, message = smtp.noop()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 518, in noop
    return self.docmd("noop")
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 425, in docmd
    return self.getreply()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 398, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/test/test_smtplib.py", line 1127, in test_with_statement_QUIT_failure
    smtp.noop()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 518, in noop
    return self.docmd("noop")
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 425, in docmd
    return self.getreply()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64/build/Lib/smtplib.py", line 398, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 20, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 3.x has failed when building commit d2a8e5b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/4/builds/510) and take a look at the build logs.
  4. Check if the failure is related to this commit (d2a8e5b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/4/builds/510

Failed tests:

  • test_smtplib

Failed subtests:

  • test_with_statement_QUIT_failure - test.test_smtplib.SMTPSimTests
  • test_with_statement - test.test_smtplib.SMTPSimTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

405 tests OK.

10 slowest tests:

  • test_mailbox: 5 min 16 sec
  • test_shelve: 3 min 17 sec
  • test_zipfile: 3 min 13 sec
  • test_concurrent_futures: 2 min 39 sec
  • test_multiprocessing_spawn: 2 min 27 sec
  • test_nntplib: 2 min 22 sec
  • test_largefile: 1 min 48 sec
  • test_dbm_ndbm: 1 min 47 sec
  • test_multiprocessing_fork: 1 min 46 sec
  • test_multiprocessing_forkserver: 1 min 41 sec

1 test failed:
test_smtplib

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_smtplib

Total duration: 10 min 7 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_smtplib.py", line 1117, in test_with_statement
    code, message = smtp.noop()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 518, in noop
    return self.docmd("noop")
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 425, in docmd
    return self.getreply()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 398, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/test/test_smtplib.py", line 1127, in test_with_statement_QUIT_failure
    smtp.noop()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 518, in noop
    return self.docmd("noop")
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 425, in docmd
    return self.getreply()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64/build/Lib/smtplib.py", line 398, in getreply
    raise SMTPServerDisconnected("Connection unexpectedly closed")
smtplib.SMTPServerDisconnected: Connection unexpectedly closed

@neonene neonene mentioned this pull request Jul 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @bedevere-bot @corona10 @the-knights-who-say-ni