Skip to content

bpo-38942: Fix possible assertion failures in csv.Dialect()#17415

Closed
ZackerySpytz wants to merge 1 commit intopython:mainfrom
ZackerySpytz:bpo-38942-csv-Dialect-assert
Closed

bpo-38942: Fix possible assertion failures in csv.Dialect()#17415
ZackerySpytz wants to merge 1 commit intopython:mainfrom
ZackerySpytz:bpo-38942-csv-Dialect-assert

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Nov 29, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 2.7 type-bug An unexpected behavior, bug, or error and removed needs backport to 2.7 labels Nov 30, 2019
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Nov 30, 2019

Do you mind to write a test?

Just create a class with a property which raises an exception and pass its instance to csv.Dialect(). Test for different attribute names and for AttributeError and non-AttributeError exceptions.

@iritkatriel
Copy link
Copy Markdown
Member

iritkatriel commented Oct 4, 2020

This is labelled awaiting merge, but from the discussion it looks like it should be labelled awaiting changes.

iritkatriel
iritkatriel requested changes Sep 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion above.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatriel
Copy link
Copy Markdown
Member

iritkatriel commented Sep 11, 2021

Actually this was already done in bio-44630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

awaiting changes type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @serhiy-storchaka @iritkatriel @bedevere-bot @ambv @the-knights-who-say-ni