Skip to content

bpo-38465: Convert the type of ob_exports in PyByteArrayObject to Py_ssize_t#16746

Merged
serhiy-storchaka merged 3 commits intopython:masterfrom
shihai1991:bpo_38465
Oct 21, 2019
Merged

bpo-38465: Convert the type of ob_exports in PyByteArrayObject to Py_ssize_t#16746
serhiy-storchaka merged 3 commits intopython:masterfrom
shihai1991:bpo_38465

Conversation

@shihai1991
Copy link
Copy Markdown
Member

@shihai1991 shihai1991 commented Oct 13, 2019

@serhiy-storchaka
Copy link
Copy Markdown
Member

LGTM. Thanks @shihai1991.

Do you mind to add a NEWS entry? Something like:

:class:`bytearray`, :class:`~array.array` and :class:`~mmap.mmap` objects allow now to export more than 2**31 buffers at a time.

@shihai1991
Copy link
Copy Markdown
Member Author

LGTM. Thanks @shihai1991.

Do you mind to add a NEWS entry? Something like:

:class:`bytearray`, :class:`~array.array` and :class:`~mmap.mmap` objects allow now to export more than 2**31 buffers at a time.

Thanks, serhiy. Your desc is good enough, so i copied your desc ;).
But I have two questions, Maybe you can give me the answer:) :

  1. do we have the clear criteria about adding new or not? i have faced this question many times~
  2. what the meaning of tilde, such as you said: ~array.array?

@ghost
Copy link
Copy Markdown

ghost commented Oct 20, 2019

  1. do we have the clear criteria about adding new or not? i have faced this question many times~

My understand if a change is visible to the users, then needs a News Entry.

  1. what the meaning of tilde, such as you said: ~array.array?

Here is an explanation:

If you prefix the content with ~, the link text will only be the last component of the target. For example, :py:meth:~Queue.Queue.get will refer to Queue.Queue.get but only display get as the link text. This does not work with all cross-reference roles, but is domain specific.

@shihai1991
Copy link
Copy Markdown
Member Author

  1. do we have the clear criteria about adding new or not? i have faced this question many times~

My understand if a change is visible to the users, then needs a News Entry.

Good explanation. That make senses.

  1. what the meaning of tilde, such as you said: ~array.array?

Here is an explanation:

If you prefix the content with ~, the link text will only be the last component of the target. For example, :py:meth:~Queue.Queue.get will refer to Queue.Queue.get but only display get as the link text. This does not work with all cross-reference roles, but is domain specific.

I am not sure I understand clearly or not: this means that we emphasize the last word(such as get of Queue.Queue.get)

@ghost
Copy link
Copy Markdown

ghost commented Oct 20, 2019

Here is an explanation:

If you prefix the content with ~, the link text will only be the last component of the target. For example, :py:meth:~Queue.Queue.get will refer to Queue.Queue.get but only display get as the link text. This does not work with all cross-reference roles, but is domain specific.

I am not sure I understand clearly or not: this means that we emphasize the last word(such as get of Queue.Queue.get)

The displayed "link text" will only be get, when the reader click the get, will navigate to Queue.Queue.get.

@serhiy-storchaka
Copy link
Copy Markdown
Member

@animalize already answered the questions, and I have nothing to add. Thank you @animalize.

@serhiy-storchaka serhiy-storchaka merged commit 06cd5b6 into python:master Oct 21, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants