Repository navigation
bpo-38187: Fix reference leak in test_tools - #16233
Merged
Merged
Conversation
ericsnowcurrently
approved these changes
Sep 17, 2019
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
This is fine as a quick fix. I'll work on fixing the Slot class, probably using a WeakKeyDictionary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the reference leak in test_tools (there is still a problem with some tests when running -R). The problem is that the
Variableclass inTools/c-analyzer/c_parser/info.pyhas a descriptor that stores state in the class-level. Therefore when running the tests multiple times, the state is leaked as there and never released.Probably this needs a better architecture so we don't need to remember to call
Variable._isglobal.instances.clear()after the tests that use Variable, but for now it fixes the leak.https://bugs.python.org/issue38187
This one was tricky to find.