Repository navigation
Conversation
hugovk
requested review from
AA-Turner,
ezio-melotti,
itamaro and
webknjaz
as code owners
October 27, 2026 20:46
itamaro
approved these changes
Oct 27, 2026
itamaro
left a comment
Contributor
There was a problem hiding this comment.
this looks good to me, but makes me think - why not have configure detect tail-call support and enable it automatically for supported toolchains? (when the flag is not specified; if the flag is specified it should win)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second suggestion at #160713 (comment).
The macOS installer uses tail-calling. This moves the tail-calling CI from a dedicated workflow, into the main workflow. This means we get coverage of tail-calling across ARM and Intel and free-threading.
Computed gotos (the non-tail-call on macOS) is still covered by most of buildbots.
One difference, we're now testing with
--with-pydebugand--fast-ci. The main effect is debug slows it a bit, and resource testing is enabled so more tests are covered, but in practice it doesn't make any difference: the three jobs take ~57m16s before, 52m16s after.We also save some CI time: the macOS job in
.github/workflows/tail-call.ymlonly ran when certain C files changed, but it was still extra work. This is now saved.