Repository navigation
gh-141174: Test re-stringifying a ForwardRef - #155689
Merged
JelleZijlstra merged 1 commit intoAug 13, 2026
Merged
Conversation
dr-carlos
changed the title
ForwardRef with STRING formatForwardRef
JelleZijlstra
approved these changes
Aug 13, 2026
JelleZijlstra
added
needs backport to 3.14
JelleZijlstra
enabled auto-merge (squash)
August 13, 2026 14:14
|
Thanks @dr-carlos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-155707 is a backport of this pull request to the 3.15 branch. |
|
GH-155708 is a backport of this pull request to the 3.14 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Aug 13, 2026
…55708) Test that re-evaluating a `ForwardRef` with `STRING` format uses the cache (cherry picked from commit 5dab490) Co-authored-by: dr-carlos <[email protected]>
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
Test that re-evaluating a `ForwardRef` with `STRING` format uses the cache
hugovk
pushed a commit
that referenced
this pull request
Aug 19, 2026
…55707) Co-authored-by: dr-carlos <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, every
ForwardRef.evaluate(format=Format.STRING)test intest_annotationlibis done with an empty__resolved_string_cache__, so there is no test that re-evaluations are correct (or that they actually use the cache).That is to say, the condition
self.__resolved_str_cache__ is Noneis always true:cpython/Lib/annotationlib.py
Line 244 in 025e7d2
Thus, this PR adds a simple test to re-stringify a stringified fwdref.
That said, I'm not 100% on whether the current test is correct: it's testing the behaviour that the cache has to be returned identically - which is the correct behaviour, and this test already tests the content of the cache - but I'm not sure if we want to cement that exact behaviour. So, happy to make it an equality (instead of identity) check if it's preferred.