Skip to content

[3.15] gh-110128: Ignore a truncated final row in csv.Sniffer - #155037

Closed
Punisheroot wants to merge 1 commit into
python:3.15from
Punisheroot:fix/js/csv-sniffer-truncated-sample
Closed

Punisheroot wants to merge 1 commit into
python:3.15from
Punisheroot:fix/js/csv-sniffer-truncated-sample

Conversation

@Punisheroot

@Punisheroot Punisheroot commented Aug 1, 2026 •

Copy link
Copy Markdown

Fixes #110128.

When a sample is truncated in the middle of its final row, the incomplete row can distort the character-frequency table used by _guess_delimiter() and cause Sniffer.sniff() to raise csv.Error.

This change excludes the final physical row from delimiter detection when the sample contains multiple rows and does not end with \r or \n. A single unterminated row remains usable.

The handling is intentionally kept within the existing _guess_delimiter() row preparation, making this a targeted maintenance-branch fix without changing the delimiter-detection algorithm. It mirrors the cut and len(rows) > 1 behavior of the rewritten Sniffer in Python 3.16. If maintainers would prefer the truncation handling at a different level, I’m happy to adjust the implementation.

Tests cover:

  • single-row samples without a trailing newline;
  • truncated samples with LF line endings;
  • truncated samples with CRLF line endings.

@hugovk

hugovk commented Oct 29, 2026

Copy link
Copy Markdown
Member

Closing per #110128 (comment), thanks anyway!

@hugovk hugovk closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants