Repository navigation
[3.13] gh-143921: Reject NUL, CR and LF in IMAP commands (GH-143922, GH-153067) (GH-153137) - #153287
Merged
serhiy-storchaka merged 1 commit intoJul 7, 2026
Merged
Conversation
…nGH-143922, pythonGH-153067) (pythonGH-153137) Combined backport of pythonGH-143922, which rejected all control characters, and pythonGH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted. (cherry picked from commit 6262704) (cherry picked from commit d0921ef) (cherry picked from commit 2981822) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]>
This was referenced Jul 7, 2026
serhiy-storchaka
enabled auto-merge (squash)
July 7, 2026 17:53
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…nGH-143922, pythonGH-153067) (pythonGH-153137) (pythonGH-153287) Combined backport of pythonGH-143922, which rejected all control characters, and pythonGH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted. (cherry picked from commit 6262704) (cherry picked from commit d0921ef) (cherry picked from commit 2981822) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]> (cherry picked from commit 71926d9) 3.10.22.x: 3.10 has no IMAP argument quoting (the _non_astring_char / _quoted machinery is 3.13+), so only the NUL/CR/LF rejection is ported. The test keeps the rejection check and checks that other control characters are still accepted, without the 3.13 quoting assertion.
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…nGH-143922, pythonGH-153067) (pythonGH-153137) (pythonGH-153287) Combined backport of pythonGH-143922, which rejected all control characters, and pythonGH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted. (cherry picked from commit 6262704) (cherry picked from commit d0921ef) (cherry picked from commit 2981822) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]> (cherry picked from commit 71926d9) 3.10.22.x: 3.10 has no IMAP argument quoting (the _non_astring_char / _quoted machinery is 3.13+), so only the NUL/CR/LF rejection is ported. The test keeps the rejection check and checks that other control characters are still accepted, without the 3.13 quoting assertion. (cherry picked from commit c1d1d62)
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…nGH-143922, pythonGH-153067) (pythonGH-153137) (pythonGH-153287) Combined backport of pythonGH-143922, which rejected all control characters, and pythonGH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted. (cherry picked from commit 6262704) (cherry picked from commit d0921ef) (cherry picked from commit 2981822) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]> (cherry picked from commit 71926d9) 3.10.22.x: 3.10 has no IMAP argument quoting (the _non_astring_char / _quoted machinery is 3.13+), so only the NUL/CR/LF rejection is ported. The test keeps the rejection check and checks that other control characters are still accepted, without the 3.13 quoting assertion.
icanhasmath
pushed a commit
to ActiveState/cpython
that referenced
this pull request
Oct 28, 2026
…nGH-143922, pythonGH-153067) (pythonGH-153137) (pythonGH-153287) Combined backport of pythonGH-143922, which rejected all control characters, and pythonGH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted. (cherry picked from commit 6262704) (cherry picked from commit d0921ef) (cherry picked from commit 2981822) Co-authored-by: Seth Michael Larson <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]> (cherry picked from commit 71926d9) 3.10.22.x: 3.10 has no IMAP argument quoting (the _non_astring_char / _quoted machinery is 3.13+), so only the NUL/CR/LF rejection is ported. The test keeps the rejection check and checks that other control characters are still accepted, without the 3.13 quoting assertion. (cherry picked from commit c1d1d62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined backport of GH-143922, which rejected all control characters, and GH-153067, which narrowed the check to NUL, CR and LF. Other control characters are valid in quoted strings and are sent quoted.
(cherry picked from commit 2981822)
Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Claude Fable 5 [email protected]