Skip to content

Fix publishing of Windows release #15006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 3 commits into from
Jul 29, 2019
Merged

Fix publishing of Windows release #15006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc8a06
Fix nuget publish
zooba Jul 29, 2019
beea7a8
Fail faster when upload fails
zooba Jul 29, 2019
50aa9a9
Finish upload with success state
zooba Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/windows-release/stage-publish-nugetorg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ jobs:
condition: and(succeeded(), eq(variables['SigningCertificate'], variables['__RealSigningCertificate']))
inputs:
command: push
packagesToPush: $(Build.BinariesDirectory)\nuget\*.nupkg'
packagesToPush: '$(Build.BinariesDirectory)\nuget\*.nupkg'
nuGetFeedType: external
publishFeedCredentials: 'Python on Nuget'
4 changes: 4 additions & 0 deletions Tools/msi/uploadrelease.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ if (-not $skipupload) {
& $plink -batch $user@$server chgrp downloads $d
& $plink -batch $user@$server chmod g-x,o+rx $d
& $pscp -batch $chm.FullName "$user@${server}:$d"
if (-not $?) { throw "Failed to upload $chm" }

$dirs = gci "$build" -Directory
if ($embed) {
Expand All @@ -107,6 +108,7 @@ if (-not $skipupload) {

if ($exe) {
& $pscp -batch $exe.FullName "$user@${server}:$d"
if (-not $?) { throw "Failed to upload $exe" }
}

if ($msi) {
Expand All @@ -115,13 +117,15 @@ if (-not $skipupload) {
& $plink -batch $user@$server chgrp downloads $sd
& $plink -batch $user@$server chmod g-x,o+rx $sd
& $pscp -batch $msi.FullName "$user@${server}:$sd"
if (-not $?) { throw "Failed to upload $msi" }
& $plink -batch $user@$server chgrp downloads $sd*
& $plink -batch $user@$server chmod g-x,o+r $sd*
}
}

& $plink -batch $user@$server chgrp downloads $d*
& $plink -batch $user@$server chmod g-x,o+r $d*
& $pscp -ls "$user@${server}:$d"
}

if (-not $skippurge) {
Expand Down