gh-145866: Convert SET_UPDATE to leave its inputs on the stack to be cleaned up by _POP_TOP#145979
Open
Sacul0457 wants to merge 3 commits intopython:mainfrom
Open
gh-145866: Convert SET_UPDATE to leave its inputs on the stack to be cleaned up by _POP_TOP#145979Sacul0457 wants to merge 3 commits intopython:mainfrom
SET_UPDATE to leave its inputs on the stack to be cleaned up by _POP_TOP#145979Sacul0457 wants to merge 3 commits intopython:mainfrom
Conversation
Sacul0457
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Python/bytecodes.c
Outdated
Comment on lines
+2172
to
+2176
| i = iterable; | ||
| DEAD(iterable); | ||
| if (err < 0) { | ||
| ERROR_NO_POP(); | ||
| } |
Member
There was a problem hiding this comment.
i should transfer ownership only after the error branch case.
Member
There was a problem hiding this comment.
Yes please. It doesn't affect the generated code at the moment, but it does affect the correctness/reasoning.
The reasoning is as follows:
- We call ERROR_NO_POP in the error branch, implying everything on the stack is a live value.
- However, the current code marks the stack value as dead before the ERROR_NO_POP.
- and 2. are contradicting each other.
Contributor
Author
|
I believe the failure isn't related to the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_POP_TOP#145866