You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@FFY00 I just noticed all those cat commands being used for install steps and, without looking further into it, I wonder if those might be opening up some security issues. Typically, we use the install utility which does ensure specific permissions etc on installed files, something cat would not do.
cat is only reading the build directory location here, install still does all the actual file touching.
That said, I really don't like this ideom. It has been around for a while, but unfortunately it's not easy to get rid of. I attempted it in GH-131761, but haven't had time to follow it through.
This change makes no sense to me. IIUC the difference between altinstall and install was only that the latter additionally installed python and python3 symlinks. These are undesirable to distributions that support multiple Python versions and handle switching themselves, hence we use altinstall. I don't see why build-details.json that is installed inside the directory for a single Python version would be controlled by the same knob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.