[3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948)#14034
Closed
miss-islington wants to merge 1 commit intopython:3.7from
Closed
[3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948)#14034miss-islington wants to merge 1 commit intopython:3.7from
miss-islington wants to merge 1 commit intopython:3.7from
Conversation
Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get deleted (join all non-daemon threads), rather than just wait until Python threads complete. * Add threading._shutdown_locks: set of Thread._tstate_lock locks of non-daemon threads used by _shutdown() to wait until all Python thread states get deleted. See Thread._set_tstate_lock(). * Add also threading._shutdown_locks_lock to protect access to threading._shutdown_locks. * Add test_finalization_shutdown() test. (cherry picked from commit 468e5fe) Co-authored-by: Victor Stinner <[email protected]>
Member
|
I prefer to wait to see how buildbots like PR #13948 merged into master, before merging the backport to 3.7. |
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
Member
|
My change introduced a giant regression! https://bugs.python.org/issue37265 ... the fix is stupid :-) #14047. I will backport the change manually using my fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a race condition at Python shutdown when waiting for threads.
Wait until the Python thread state of all non-daemon threads get
deleted (join all non-daemon threads), rather than just wait until
Python threads complete.
of non-daemon threads used by _shutdown() to wait until all Python
thread states get deleted. See Thread._set_tstate_lock().
threading._shutdown_locks.
(cherry picked from commit 468e5fe)
Co-authored-by: Victor Stinner [email protected]
https://bugs.python.org/issue36402