Skip to content

gh-131888: fix ResourceWarning in test_ftplib - #131889

Merged
vstinner merged 1 commit into
python:mainfrom
graingert:fix-resource-warning-in-test-ftplib
Apr 2, 2025
Merged

gh-131888: fix ResourceWarning in test_ftplib#131889
vstinner merged 1 commit into
python:mainfrom
graingert:fix-resource-warning-in-test-ftplib

Conversation

@graingert

@graingert graingert commented Mar 30, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 30, 2025
Closed
@graingert
graingert marked this pull request as ready for review March 30, 2025 06:44
@graingert graingert closed this Mar 30, 2025
@graingert graingert reopened this Mar 30, 2025
vstinner
vstinner approved these changes Apr 2, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't fully understand this code, but the logic looks correct.

@vstinner

vstinner commented Apr 2, 2025

Copy link
Copy Markdown
Member

I would be more confident if I could reproduce the test_ftplib (env changed) failures, but I don't know how to trigger this issue. So let me merge this change and see how it goes on the CI.

@vstinner
vstinner merged commit b0f77c4 into python:main Apr 2, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 2, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2025
@graingert @miss-islington
pythongh-131888: fix ResourceWarning in test_ftplib (pythonGH-131889)
e95e719 
(cherry picked from commit b0f77c4)

Co-authored-by: Thomas Grainger <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2025
@graingert @miss-islington
pythongh-131888: fix ResourceWarning in test_ftplib (pythonGH-131889)
90a76ea 
(cherry picked from commit b0f77c4)

Co-authored-by: Thomas Grainger <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 2, 2025

Copy link
Copy Markdown

GH-132009 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 2, 2025
@bedevere-app

bedevere-app Bot commented Apr 2, 2025

Copy link
Copy Markdown

GH-132010 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 2, 2025
vstinner pushed a commit that referenced this pull request Apr 2, 2025
@miss-islington @graingert
[3.12] gh-131888: fix ResourceWarning in test_ftplib (GH-131889) (#13…
e4fe4d9 
…2010)

gh-131888: fix ResourceWarning in test_ftplib (GH-131889)
(cherry picked from commit b0f77c4)

Co-authored-by: Thomas Grainger <[email protected]>
vstinner pushed a commit that referenced this pull request Apr 2, 2025
@miss-islington @graingert
[3.13] gh-131888: fix ResourceWarning in test_ftplib (GH-131889) (#13…
b1cd14b 
…2009)

gh-131888: fix ResourceWarning in test_ftplib (GH-131889)
(cherry picked from commit b0f77c4)

Co-authored-by: Thomas Grainger <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 2, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.x (tier-2) has failed when building commit b0f77c4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/14/builds/7460) and take a look at the build logs.
  4. Check if the failure is related to this commit (b0f77c4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/14/builds/7460

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.14/test/test_perf_profiler.py", line 364, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_kr2vtj2o/tmpx7vysqc4/perftest.py' not found in 'python3.14 4080650 755320.292886:          1 cycles:Pu: \n\t    ffffa690eac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4080650 755320.292917:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffa690eac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4080650 755320.293079:          1 cycles:Pu: \n\t    ffffa69094c0 get_midr_from_mcpu+0xa0 (inlined)\n\t    ffffa69094c0 init_cpu_features+0xa0 (inlined)\n\t    ffffa69094c0 dl_platform_init+0xa0 (inlined)\n\t    ffffa69094c0 _dl_sysdep_start+0xa0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa690ab17 _dl_start_final+0x5ab (inlined)\n\t    ffffa690ab17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa690ead3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4080650 755320.293095:        319 cycles:Pu: \n\t    ffffa69094b8 tunable_strcmp+0x98 (inlined)\n\t    ffffa69094b8 get_midr_from_mcpu+0x98 (inlined)\n\t    ffffa69094b8 init_cpu_features+0x98 (inlined)\n\t    ffffa69094b8 dl_platform_init+0x98 (inlined)\n\t    ffffa69094b8 _dl_sysdep_start+0x98 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa690ab17 _dl_start_final+0x5ab (inlined)\n\t    ffffa690ab17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa690ead3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4080650 755320.294145:       2777 cycles:Pu: \n\t    ffffa6900244 elf_machine_lazy_rel+0x2e4 (inlined)\n\t    ffffa6900244 elf_dynamic_do_Rela+0x2e4 (inlined)\n\t    ffffa6900244 _dl_relocate_object+0x2e4 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa690c44f dl_main+0x164f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa69095ff _dl_sysdep_start+0x1df (/usr/lib/ld
romConfig+0x15f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          63467f pymain_init+0x10b (inlined)\n\t          63467f pymain_main+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          634733 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t    ffffa66a625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa66a633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41ee6f _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\npython3.14 4080650 755320.297650:    1608166 cycles:Pu: \n\t    ffffa6725bd4 strrchr+0x14 (/usr/lib64/libc.so.6)\n\t          4f7d7f find_signature+0xbfb (inlined)\n\t          4f7d7f _PyType_DocWithoutSignature+0xbfb (inlined)\n\t          4f7d7f type_dict_set_doc+0xbfb (inlined)\n\t          4f7d7f type_ready_fill_dict+0xbfb (inlined)\n\t          4f7d7f type_ready+0xbfb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          4f9133 init_static_type+0x1d3 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          4c654f _PyTypes_InitTypes+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          6067c7 pycore_init_types+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          606633 pycore_interp_init+0x12b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60649b pyinit_config+0x237 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          603a2b pyinit_core+0x28f (inlined)\n\t          603a2b Py_InitializeFromConfig+0x28f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          63467f pymain_init+0x10b (inlined)\n\t          63467f pymain_main+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          634733 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t    ffffa66a625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffa66a633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41ee6f _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\npython3.14 4080650 755320.300300:    3928482 cycles:Pu: \n\t    ffffa672ac14 __strlen_asimd+0x14 (/usr/lib64/libc.so.6)\n\t          50d15b PyUnicode_FromString+0x13 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          621da7 list_stdlib_module_names+0x33 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          61e92b _PySys_InitCore+0x647 (inlined)\n\t          61e92b _PySys_Create+0x647 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60669f pycore_interp_init+0x197 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60649b pyinit_config+0x237 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          603a2b pyinit_core+0x28f (inlined)\n\t          603a2b Py_InitializeFromConfig+0x28f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          63467f pymain_init+0x10b (inlined)\n\t          63467f pymain_main+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.14/test/test_perf_profiler.py", line 364, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_tdabj1a5/tmp1gaxi0lf/perftest.py' not found in 'python3.14 4100632 755413.537395:          1 cycles:Pu: \n\t    ffffb44ffac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4100632 755413.537423:          1 cycles:Pu: \n\tffffaa282d37fc78 [unknown] ([unknown])\n\tffffaa282d38049c [unknown] ([unknown])\n\tffffaa282bf215e4 [unknown] ([unknown])\n\t    ffffb44ffac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4100632 755413.538105:          1 cycles:Pu: \n\t    ffffb44ecb04 check_match+0x24 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44ed017 do_lookup_x+0x397 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44ed833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44f16ff resolve_map+0x79f (inlined)\n\t    ffffb44f16ff elf_machine_rela+0x79f (inlined)\n\t    ffffb44f16ff elf_dynamic_do_Rela+0x79f (inlined)\n\t    ffffb44f16ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fd3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fa5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fbb17 _dl_start_final+0x5ab (inlined)\n\t    ffffb44fbb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44ffad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4100632 755413.538126:        297 cycles:Pu: \n\t    ffffb44f1638 elf_dynamic_do_Rela+0x6d8 (inlined)\n\t    ffffb44f1638 _dl_relocate_object+0x6d8 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fd3d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fa5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44fbb17 _dl_start_final+0x5ab (inlined)\n\t    ffffb44fbb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffb44ffad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.14 4100632 755413.539126:        811 cycles:Pu: \n\t    ffffb430bfbc _int_malloc+0x3bc (/usr/lib64/libc.so.6)\n\t    ffffb430d5cb malloc+0x22b (/usr/lib64/libc.so.6)\n\t    ffffb42a1b3b _nl_intern_locale_data+0x9b (/usr/lib64/libc.so.6)\n\t    ffffb42a18ff _nl_load_locale_from_archive+0x45f (/usr/lib64/libc.so.6)\n\t    ffffb42a0c7f _nl_find_locale+0xff (/usr/lib64/libc.so.6)\n\t    ffffb42a344f setlocale+0x3cf (/usr/lib64/libc.so.6)\n\t          603453 _Py_SetLocaleFromEnv+0x17 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60237b _PyPreConfig_Read+0xc7 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60356f _Py_PreInitializeFromPyArgv+0x103 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          6345c3 pymain_init+0x4f (inlined)\n\t          6345c3 pymain_main+0x4f (/home/buildbot/buildarea/3.x.cstratak-fedora-s
dline_SetArgv+0x26b (inlined)\n\t          60251f _PyPreConfig_Read+0x26b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60356f _Py_PreInitializeFromPyArgv+0x103 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          6345c3 pymain_init+0x4f (inlined)\n\t          6345c3 pymain_main+0x4f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          634733 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t    ffffb429625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffb429633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41ee6f _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\npython3.14 4100632 755413.540176:      94379 cycles:Pu: \n\t          54eea8 intern_static+0x11ce4 (inlined)\n\t          54eea8 _PyUnicode_InternStatic+0x11ce4 (inlined)\n\t          54eea8 _PyUnicode_InitStaticStrings+0x11ce4 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          52dcbb init_global_interned_strings+0x83 (inlined)\n\t          52dcbb _PyUnicode_InitGlobalObjects+0x83 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60653f pycore_init_global_objects+0x37 (inlined)\n\t          60653f pycore_interp_init+0x37 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60649b pyinit_config+0x237 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          603a2b pyinit_core+0x28f (inlined)\n\t          603a2b Py_InitializeFromConfig+0x28f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          63467f pymain_init+0x10b (inlined)\n\t          63467f pymain_main+0x10b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          634733 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t    ffffb429625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffb429633b __libc_start_main@@GLIBC_2.34+0x9b (/usr/lib64/libc.so.6)\n\t          41ee6f _start+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\npython3.14 4100632 755413.541845:    2249055 cycles:Pu: \n\t          4f78dc type_add_members+0x758 (inlined)\n\t          4f78dc type_ready_fill_dict+0x758 (inlined)\n\t          4f78dc type_ready+0x758 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          4f9133 init_static_type+0x1d3 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          4c654f _PyTypes_InitTypes+0x2f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          6067c7 pycore_init_types+0x23 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          606633 pycore_interp_init+0x12b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          60649b pyinit_config+0x237 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          603a2b pyinit_core+0x28f (inlined)\n\t          603a2b Py_InitializeFromConfig+0x28f (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.14)\n\t          63467f pymain_init+0x10b (inlined)\n\t          63467f pymain_main+0x10b (/home/buildbot/buildarea/3.x.cstratak-f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert @vstinner @bedevere-bot