gh-126599: Refactor the _PyOptimizer APIs#126853
Merged
brandtbucher merged 18 commits intopython:mainfrom Jan 16, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi this is my draft to remove the
_PyOptimizer_NewCounterand_PyOptimizer_NewUOpOptimizerAPIs, where the related tests are removed or skipped.For the most challenging
_PyOptimizer_Optimize, I'm still trying to figure out how to achieve its functionality in generated interpreter. To remove the "artificial boundaries", should we just remove this API call and replace its code in theJUMP_BACKWARD,_EXIT_TRACEand_DYNAMIC_EXITinstruction cases?_PyOptimizerAPIs #126599