bpo-33608: Fix PyEval_InitThreads() warning#12346
Merged
vstinner merged 1 commit intopython:masterfrom Mar 15, 2019
vstinner:fix_ceval_warn
Merged
bpo-33608: Fix PyEval_InitThreads() warning#12346vstinner merged 1 commit intopython:masterfrom vstinner:fix_ceval_warn
vstinner merged 1 commit intopython:masterfrom
vstinner:fix_ceval_warn
Conversation
The function has no return value.
Fix the following warning on Windows:
python\ceval.c(180): warning C4098: 'PyEval_InitThreads':
'void' function returning a value
ericsnowcurrently
approved these changes
Mar 15, 2019
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Thanks for doing this, @vstinner! LGTM
Member
Author
You're welcome. I noticed this warning while looking at AppVeyor/VSTS on my unrelated PR for https://bugs.python.org/issue36301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function has no return value.
Fix the following warning on Windows:
https://bugs.python.org/issue33608