gh-120868: Fix breaking change in logging.config when using QueueHandler#120872
Merged
vsajip merged 6 commits intopython:mainfrom Jun 27, 2024
Merged
gh-120868: Fix breaking change in logging.config when using QueueHandler#120872vsajip merged 6 commits intopython:mainfrom
logging.config when using QueueHandler#120872vsajip merged 6 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120868 was caused by an eager construction of
multiprocessing.Managerused to check if thequeuepassed in to the logging config was an instance ofmultiprocessing.Manager.Queue/multiprocessing.Manager.JoinableQueue. This could cause unexpected exceptions in environments where amultiprocessing.Managercouldn't be created.The proposed fix moves the check for these classes, and creation of
multiprocessing.Managerwhich is necessary for this, to a point where we've ruled out all other valid options forqueue, and are certain thatmultiprocessing.Managerhas been used to produce the object passed viaqueue.logging.config.DictConfigwithlogging.handlers.QueueHandleron read-only file systems #120868