Skip to content

gh-120868: Fix breaking change in logging.config when using QueueHandler#120872

Merged
vsajip merged 6 commits intopython:mainfrom
provinzkraut:fix-gh-120868
Jun 27, 2024
Merged

gh-120868: Fix breaking change in logging.config when using QueueHandler#120872
vsajip merged 6 commits intopython:mainfrom
provinzkraut:fix-gh-120868

Conversation

@provinzkraut
Copy link
Contributor

@provinzkraut provinzkraut commented Jun 22, 2024

#120868 was caused by an eager construction of multiprocessing.Manager used to check if the queue passed in to the logging config was an instance of multiprocessing.Manager.Queue / multiprocessing.Manager.JoinableQueue. This could cause unexpected exceptions in environments where a multiprocessing.Manager couldn't be created.

The proposed fix moves the check for these classes, and creation of multiprocessing.Manager which is necessary for this, to a point where we've ruled out all other valid options for queue, and are certain that multiprocessing.Manager has been used to produce the object passed via queue.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants