Skip to content

bpo-35555: IDLE: Gray out Code Context menu item on non-editors #11282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 3 commits into from
Dec 23, 2018
Merged

bpo-35555: IDLE: Gray out Code Context menu item on non-editors #11282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f236f0c
bpo-35555: IDLE: Gray out Code Context menu on non-editors
csabella Dec 21, 2018
39a6afc
Merge remote-tracking branch 'origin/master' into pr_11282
terryjreedy Dec 23, 2018
334f52c
idlelib NEWS entry
terryjreedy Dec 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ Released on 2019-10-20?
======================================


bpo-35555: Gray out Code Context menu entry when it's not applicable.

bpo-22703: Improve the Code Context and Zoom Height menu labels.
The Code Context menu label now toggles between Show/Hide Code Context.
The Zoom Height menu now toggles between Zoom/Restore Height.
Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/outwin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ def __init__(self, *args):
EditorWindow.__init__(self, *args)
self.text.bind("<<goto-file-line>>", self.goto_file_line)
self.text.unbind("<<toggle-code-context>>")
self.menudict['options'].entryconfig('*Code Context',
state='disabled')

# Customize EditorWindow
def ispythonsource(self, filename):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2018-12-21-18-44-30.bpo-35555.M58_K3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Gray out Code Context menu entry when it's not applicable.

@terryjreedy terryjreedy Mar 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this in the macOS instead of IDLE section confused Ned into thinking this was a Mac-only change. We should check each other's blurb directories. It is too easy to get the wrong one.