Skip to content

[3.11] bpo-43153: Don't mask PermissionError with NotADirectoryError during tempdirectory cleanup (GH-29940) - #112754

Merged
serhiy-storchaka merged 1 commit into
python:3.11from
miss-islington:backport-8cdfee1-3.11
Dec 5, 2023
Merged

serhiy-storchaka merged 1 commit into
python:3.11from
miss-islington:backport-8cdfee1-3.11

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

(cherry picked from commit 8cdfee1)

Co-authored-by: Ken Jin [email protected]
Co-authored-by: andrei kulakov [email protected]
Co-authored-by: Serhiy Storchaka [email protected]

…ing tempdirectory cleanup (pythonGH-29940)

(cherry picked from commit 8cdfee1)

Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: andrei kulakov <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) December 5, 2023 13:34
@serhiy-storchaka
serhiy-storchaka merged commit 23920a0 into python:3.11 Dec 5, 2023
@miss-islington
miss-islington deleted the backport-8cdfee1-3.11 branch January 2, 2026 16:56
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
…or` during tempdirectory cleanup (pythonGH-29940) (pythonGH-112754)

(cherry picked from commit 8cdfee1)

Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: andrei kulakov <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 23920a0)
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull request Oct 28, 2026
…or` during tempdirectory cleanup (pythonGH-29940) (pythonGH-112754)

(cherry picked from commit 8cdfee1)

Co-authored-by: Ken Jin <[email protected]>
Co-authored-by: andrei kulakov <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 23920a0)
(cherry picked from commit e3888c0)

3.9.25.x: 3.9's TemporaryDirectory has no ignore_cleanup_errors (added in
3.10), so _rmtree() gains a private ignore_errors parameter that is
always False here; it keeps the code in the 3.10/3.11 shape for the
follow-up fixes. The ignore_cleanup_errors test is not ported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants