DOC: emphasize the need to always call PySequence_Fast#11140
Merged
benjaminp merged 5 commits intopython:masterfrom Sep 12, 2019
Merged
DOC: emphasize the need to always call PySequence_Fast#11140benjaminp merged 5 commits intopython:masterfrom
benjaminp merged 5 commits intopython:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySequence_Fast()should always be used (and the result checked) before any of the otherPySequence_Fast*family of functions. As an implementation detail, CPython can circumvent this ifPyTuple_CheckExact()passes, but that does not work on PyPy.xref numpy/numpy#12524