gh-105857: Document that asyncio subprocess std{in,out,err} can be file handles#107986
Merged
ambv merged 1 commit intopython:mainfrom Aug 22, 2023
Hels15:third
Merged
gh-105857: Document that asyncio subprocess std{in,out,err} can be file handles#107986ambv merged 1 commit intopython:mainfrom Hels15:third
ambv merged 1 commit intopython:mainfrom
Hels15:third
Conversation
Hels15
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
AA-Turner
changed the title
AA-Turner
added
needs backport to 3.11
Contributor
Contributor
|
Sorry, @Hels15 and @ambv, I could not cleanly backport this to |
|
GH-108332 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 22, 2023
… be file handles (pythonGH-107986) stdin/out can be filehandles -> add to docs. (cherry picked from commit 13966da) Co-authored-by: Hadházy Tamás <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Aug 22, 2023
…n be file handles (GH-107986) (#108332) (cherry picked from commit 13966da) Co-authored-by: Hadházy Tamás <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docs passing a filehandle isn't mentioned as an option. Looking at the underlying code, I see it definitely is supported there's a check for the parameter being an integer and the handle is used directly.
📚 Documentation preview 📚: https://cpython-previews--107986.org.readthedocs.build/