GH-89812: Simplify creation of symlinks in pathlib tests.#106061
Merged
barneygale merged 1 commit intopython:mainfrom Jun 30, 2023
Merged
GH-89812: Simplify creation of symlinks in pathlib tests.#106061barneygale merged 1 commit intopython:mainfrom
barneygale merged 1 commit intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
PathTest.dirlink()function. Symlinks inPathTest.setUp()are created usingos.symlink()directly; symlinks in test functions usePath.symlink_to()in order to make the tests applicable to a (near-)futureAbstractPathclass.