Skip to content

bpo-35196: optimize Squeezer's write() interception #10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 26 commits into from
Jan 13, 2019
Merged

bpo-35196: optimize Squeezer's write() interception #10454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2525992
bpo-35196: optimize Squeezer's write() interception
taleinat Nov 10, 2018
6b60df6
remove dead, old test code from test_squeezer.py
taleinat Nov 10, 2018
0e30a72
bpo-35196: fix test_reload() failing
taleinat Nov 11, 2018
76e8ea2
remove unnecessary additional check which doesn't improve performance
taleinat Dec 24, 2018
65ee056
instantiate Squeezer only on PyShell windows
taleinat Dec 24, 2018
485d954
hard-code tab width to 8 (always true for IDLE's shell)
taleinat Dec 24, 2018
22f1c4f
Merge remote-tracking branch 'origin/master' into pr_10454
terryjreedy Dec 27, 2018
5f0e69f
Add blurb and idlelib news.
terryjreedy Dec 27, 2018
23af040
Condense character width comment and update to 8.6.
terryjreedy Dec 27, 2018
8a4ca02
In test, change deprecated assertEquals to assertEqual.
terryjreedy Dec 27, 2018
1f56ee8
Add coverage information. Details in comment.
terryjreedy Dec 28, 2018
390d089
Add X windows comment.
terryjreedy Dec 28, 2018
8e12a81
Move PyShell only code to pyshell.PyShell.
terryjreedy Dec 28, 2018
ee25bac
Use existing local reference.
terryjreedy Dec 28, 2018
9ac5156
Fix comments (# Cap ... length ... end.) in squeezer.py.
terryjreedy Dec 28, 2018
6e1556d
Fix comments in test_squeezer to PEP standards. Uncomment test
terryjreedy Dec 28, 2018
2f0e0a5
fix bug in setting Squeezer._instance_weakref and improve test coverage
taleinat Jan 3, 2019
37daa8a
add a do-nothing test case for Squeezer.reload(), and fix test cleanup
taleinat Jan 3, 2019
62ca6d3
re-format inline comments
taleinat Jan 3, 2019
3f77905
Update test_squeezer, trigger retest
terryjreedy Jan 11, 2019
17bc8d9
Reverse asssertions to test 2nd
terryjreedy Jan 11, 2019
69eaa4f
Change taked to taken
terryjreedy Jan 12, 2019
3c3fb9d
fix test_reload() check that zero_with_char has increased
taleinat Jan 12, 2019
05543b0
Change 'name' to 'font' in load_font Font().
terryjreedy Jan 12, 2019
66c01e5
Reset font size by resetting font option.
terryjreedy Jan 12, 2019
ae8a483
minor code cleanup in Squeezer's mywrite()
taleinat Jan 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ Released on 2019-10-20?
======================================


bpo-35196: Speed up squeezer line counting.

bpo-35208: Squeezer now counts wrapped lines before newlines.

bpo-35555: Gray out Code Context menu entry when it's not applicable.
Expand Down
3 changes: 0 additions & 3 deletions Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,6 @@ def __init__(self, flist=None, filename=None, key=None, root=None):
text.bind("<<zoom-height>>", self.ZoomHeight(self).zoom_height_event)
text.bind("<<toggle-code-context>>",
self.CodeContext(self).toggle_code_context_event)
squeezer = self.Squeezer(self)
text.bind("<<squeeze-current-text>>",
squeezer.squeeze_current_text_event)

def _filename_to_unicode(self, filename):
"""Return filename as BMP unicode so diplayable in Tk."""
Expand Down
Loading