Correct some "-operator" mentions#10341
Conversation
|
What is wrong with the current wording? |
"X operator" is not a compound term to be written as "X-operator". |
|
What is wrong in |
My previous reply applies to both cases: "X-operator" is not a compound term to be written as such. Regarding "double-star": it isn't referred with that name in any other place in the documentation, while "**" is, even where the "double-star-operator" reference point to. |
|
Sorry, I'm not competent to review this PR. |
It's alright :) Neither of us is a native English speaker. We are just doing our best. |
scotchka
left a comment
There was a problem hiding this comment.
I think the changes are reasonable. The meaning is clear without the dash, which is visually cluttering. And "**" is more explicit than "double star".
|
@merwok perhaps we can merge this? |
|
Thanks @andresdelfino for the PR, and @merwok for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7. |
|
GH-12573 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @andresdelfino and @merwok, I could not cleanly backport this to |
Change "star-operator" to "* operator". (cherry picked from commit dfd775a) Co-authored-by: Andre Delfino <[email protected]>
Change "star-operator" to "* operator". (cherry picked from commit dfd775a) Co-authored-by: Andre Delfino <[email protected]>
|
IMO, this should not have been committed. The prior wording made it clear that the double-star for dictionary unpacking was distinct from the Please place preference on the intent of the original writer of the docs. |
|
Hi, @rhettinger ! While I agree that making it clear that ** does not refer to the operator implemented by pow is great, I don't see how the previous wording made that explicit. Also, note that we are saying "*" instead of "star" while talking about tuple/list unpacking in the previous paragraph, which would cause the same confusion. I think we could improve the wording by explicitly saying that "**" does not refer to the operator implemented by the special method "pow", likewise for "*". What do you think? If you agree, I'll make the PR. |
|
There is an example immediately below the change in collections.rst that should make it clear in context that A clarifying remark (e.g. "not to be confused with exponentiation") could be helpful, but I don't have a sense of how likely that confusion is. |
This reverts commit dfd775a.
No description provided.