Repository navigation
test_importlib: test_read_bytes() fails on AMD64 Windows8.1 Non-Debug 3.x #89241
Description
| BPO | 45078 |
|---|---|
| Nosy | @brettcannon, @jaraco, @vstinner, @FFY00 |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-09-13.00:03:05.018>
created_at = <Date 2021-09-01.15:54:48.722>
labels = ['tests', '3.11']
title = 'test_importlib: test_read_bytes() fails on AMD64 Windows8.1 Non-Debug 3.x'
updated_at = <Date 2021-09-13.00:03:05.017>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2021-09-13.00:03:05.017>
actor = 'jaraco'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-13.00:03:05.018>
closer = 'jaraco'
components = ['Tests']
creation = <Date 2021-09-01.15:54:48.722>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 45078
keywords = ['patch']
message_count = 8.0
messages = ['400847', '400850', '400852', '400887', '400890', '400891', '400893', '401678']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'jaraco', 'vstinner', 'FFY00']
pr_nums = ['28120']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45078'
versions = ['Python 3.11']
Activity
vstinner commentedon Sep 1, 2021
Since build 305 (commit a40675c), test_importlib fails on AMD64 Windows8.1 Non-Debug 3.x:
https://buildbot.python.org/all/#/builders/405/builds/305
The last successful build wa the build 304 (commit ee03bad).
Sadly, the test doesn't report the 'actual' variable value when the test fails.
======================================================================
FAIL: test_read_bytes (test.test_importlib.test_files.OpenNamespaceTests)
----------------------------------------------------------------------
vstinner commentedon Sep 1, 2021
Interesting commits from:
$ git log ee03bad..a40675c
commit aaa83cd
Author: Jason R. Coombs <[email protected]>
Date: Thu Jul 29 21:05:05 2021 -0400
vstinner commentedon Sep 1, 2021
Maybe Git does change the end of line of Lib/test/test_importlib/namespacedata01/utf-8.file file, even if .gitattributes contains:
"Lib/test/test_importlib/namespacedata01/* -text"
jaraco commentedon Sep 2, 2021
There is an issue where that file originally got EOL conversions, so all Windows buildbots were failing (bpo-44779).
I'd thought we'd worked around the issue by pushing out a PR that deleted the file and ensuring it ran on the buildbots (#27436 (comment)).
I knew it was a risk, however, that either that PR failed to checkout on the buildbot, checked out on a different shard, or that another PR subsequently managed to check out the code without the .gitattributes fix.
jaraco commentedon Sep 2, 2021
I'm going to attempt that technique again and see if it's sufficient to bypass the symptom.
jaraco commentedon Sep 2, 2021
I've submitted a PR that deletes the file and requested it be built by the buildbots, but I also see that that bot hasn't built anything in 7 days (https://buildbot.python.org/all/#/builders/405), so I'm not hopeful my request for it to build that change will have any effect on that builder.
jaraco commentedon Sep 2, 2021
I'm not confident that I can get the message to the buildbot, so I sent a message to [email protected] requesting to run the workaround on the buildbot. The message was flagged for moderation. My hope is that eventually goes through and will address the issue.
jaraco commentedon Sep 13, 2021
The builder is now passing after the buildbot owner reset the checkout.