test_inspect fails in refleak mode

@ambv

BPO	44808
Nosy	@ambv, @markshannon, @pablogsal, @miss-islington, @akulakov
PRs	bpo-44808: Fix test_inspect in refleak mode #27544 [3.10] bpo-44808: Fix test_inspect in refleak mode (GH-27544) #27546 bpo-44808: fixes test for interactive inspect getsource of a class #27571 [3.10] bpo-44808: fixes test for interactive inspect getsource of a class (GH-27571) #27578

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-08-03.13:08:55.600>
created_at = <Date 2021-08-02.09:55:50.687>
labels = ['3.10', '3.11']
title = 'test_inspect fails in refleak mode'
updated_at = <Date 2021-08-03.13:08:55.600>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2021-08-03.13:08:55.600>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-03.13:08:55.600>
closer = 'lukasz.langa'
components = []
creation = <Date 2021-08-02.09:55:50.687>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 44808
keywords = ['patch']
message_count = 16.0
messages = ['398744', '398745', '398747', '398749', '398750', '398752', '398753', '398754', '398755', '398757', '398759', '398767', '398788', '398812', '398824', '398825']
nosy_count = 5.0
nosy_names = ['lukasz.langa', 'Mark.Shannon', 'pablogsal', 'miss-islington', 'andrei.avk']
pr_nums = ['27544', '27546', '27571', '27578']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44808'
versions = ['Python 3.10', 'Python 3.11']

From https://bugs.python.org/issue44206 :

File "/home/mark/repos/cpython/Lib/inspect.py", line 1154, in walktree
classes.sort(key=attrgetter('__module__', '__name__'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '<' not supported between instances of 'str' and 'module'

I can reproduce that failure with a debug build and either of
./python -m test -R 3:3 test_inspect
./python -m test test_inspect -F

I'm bisecting

f468ede is the first bad commit
commit f468ede
Author: Miss Islington (bot) <[email protected]>
Date: Fri Jul 30 10:46:42 2021 -0700

bpo-44648: Fix error type in inspect.getsource() in interactive session (GH-27171) (GH-27495)

(cherry picked from commit 48a62559dfaf775e4f1cc56b19379c799e8e2587)

Co-authored-by: andrei kulakov <[email protected]>

Lib/inspect.py | 2 ++
Lib/test/test_inspect.py | 17 ++++++++++++++++-
.../Library/2021-07-15-16-51-32.bpo-44648.2o49TB.rst | 3 +++
3 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 Misc/NEWS.d/next/Library/2021-07-15-16-51-32.bpo-44648.2o49TB.rst

The reason buildbots have not catched this is because the re-run login seems to not detect the problem on the second run:

./python.exe -m test test_inspect -j 1 -u all -W --slowest --fail-env-changed --timeout=11700 -R 3:3 -u-cpu -w

WARNING: Disable --verbose3 because it's incompatible with --huntrleaks: see http://bugs.python.org/issue27103
0:00:00 load avg: 2.73 Run tests in parallel using 1 child processes (timeout: 3 hour 15 min, worker timeout: 3 hour 20 min)
0:00:03 load avg: 2.92 [1/1/1] test_inspect failed (1 error)
beginning 6 repetitions
123456
.test test_inspect failed -- Traceback (most recent call last):
  File "/Users/pgalindo3/github/cpython/Lib/test/test_inspect.py", line 398, in test_getclasses
    tree = inspect.getclasstree([cls[1] for cls in classes])
  File "/Users/pgalindo3/github/cpython/Lib/inspect.py", line 1185, in getclasstree
    return walktree(roots, children, None)
  File "/Users/pgalindo3/github/cpython/Lib/inspect.py", line 1158, in walktree
    results.append(walktree(children[c], children, c))
  File "/Users/pgalindo3/github/cpython/Lib/inspect.py", line 1154, in walktree
    classes.sort(key=attrgetter('__module__', '__name__'))
TypeError: '<' not supported between instances of 'str' and 'module'

== Tests result: FAILURE ==

10 slowest tests:

test_inspect: 3.4 sec

1 test failed:
test_inspect

1 re-run test:
test_inspect

0:00:03 load avg: 2.92 Re-running failed tests in verbose mode
0:00:03 load avg: 2.92 Re-running test_inspect in verbose mode (matching: test_getclasses)
beginning 6 repetitions
123456
test_getclasses (test.test_inspect.TestRetrievingSourceCode) ... ok

----------------------------------------------------------------------

Ran 1 test in 0.001s