Skip to content

Some target-related rules are unreachable in the grammar #88551

Closed

Description

@lysnikolaou
BPO 44385
Nosy @gvanrossum, @lysnikolaou, @pablogsal, @miss-islington
PRs
  • bpo-44385: Remove unused grammar rules #26655
  • [3.10] bpo-44385: Remove unused grammar rules (GH-26655) #26657
  • [3.9] bpo-44385: Remove unused grammar rules (GH-26655) #26659
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/lysnikolaou'
    closed_at = <Date 2021-06-10.22:38:54.008>
    created_at = <Date 2021-06-10.21:42:26.760>
    labels = ['interpreter-core', 'type-bug', '3.11']
    title = 'Some target-related rules are unreachable in the grammar'
    updated_at = <Date 2021-06-10.22:52:56.372>
    user = 'https://github.com/lysnikolaou'

    bugs.python.org fields:

    activity = <Date 2021-06-10.22:52:56.372>
    actor = 'miss-islington'
    assignee = 'lys.nikolaou'
    closed = True
    closed_date = <Date 2021-06-10.22:38:54.008>
    closer = 'lys.nikolaou'
    components = ['Parser']
    creation = <Date 2021-06-10.21:42:26.760>
    creator = 'lys.nikolaou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44385
    keywords = ['patch']
    message_count = 4.0
    messages = ['395577', '395581', '395582', '395586']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'lys.nikolaou', 'pablogsal', 'miss-islington']
    pr_nums = ['26655', '26657', '26659']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue44385'
    versions = ['Python 3.11']

    Activity

    1. lysnikolaou commented on Jun 10, 2021

      @lysnikolaou
      MemberAuthor

      Three rules (targets, target and t_atom) in the grammar are unreachable. We were using them at some point in the past, but we never removed them when we replaced them with other rules.

    2. self-assigned this
      on Jun 10, 2021
    3. added
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      type-bugAn unexpected behavior, bug, or error
      3.11only security fixes
      on Jun 10, 2021
    4. self-assigned this
      on Jun 10, 2021
    5. added
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      type-bugAn unexpected behavior, bug, or error
      on Jun 10, 2021
    6. miss-islington commented on Jun 10, 2021

      @miss-islington
      Contributor

      New changeset e7b4644 by Lysandros Nikolaou in branch 'main':
      bpo-44385: Remove unused grammar rules (GH-26655)
      e7b4644

    7. miss-islington commented on Jun 10, 2021

      @miss-islington
      Contributor

      New changeset 3e13742 by Miss Islington (bot) in branch '3.10':
      bpo-44385: Remove unused grammar rules (GH-26655)
      3e13742

    8. miss-islington commented on Jun 10, 2021

      @miss-islington
      Contributor

      New changeset 3ce35bf by Lysandros Nikolaou in branch '3.9':
      [3.9] bpo-44385: Remove unused grammar rules (GH-26655) (GH-26659)
      3ce35bf

    9. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    3.11only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions