Repository navigation
[sqlite3] Improve sqlite3_value_text() error handling #88019
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2022-03-02.06:41:01.374>
created_at = <Date 2021-04-15.10:00:09.823>
labels = ['extension-modules', 'type-bug', '3.9', '3.10', '3.11']
title = '[sqlite3] Improve sqlite3_value_text() error handling'
updated_at = <Date 2022-03-02.06:41:01.373>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2022-03-02.06:41:01.373>
actor = 'erlendaasland'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-02.06:41:01.374>
closer = 'erlendaasland'
components = ['Extension Modules']
creation = <Date 2021-04-15.10:00:09.823>
creator = 'erlendaasland'
dependencies = []
files = ['49961']
hgrepos = []
issue_num = 43853
keywords = ['patch']
message_count = 17.0
messages = ['391124', '394267', '395109', '395112', '399075', '399084', '399114', '399120', '400174', '400288', '400292', '400296', '400319', '401565', '411771', '413620', '414325']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'berker.peksag', 'serhiy.storchaka', 'JelleZijlstra', 'pablogsal', 'miss-islington', 'erlendaasland']
pr_nums = ['25422', '26534', '27627', '27642', '27922', '27952', '27953', '31030', '31586']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43853'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
Activity
erlend-aasland commentedon Apr 15, 2021
Fix sqlite3_value_text() usage:
Quoting the SQLite docs:
"As long as the input parameter is correct, these routines can only fail if an out-of-memory error occurs"
See also:
[-][sqlite] Fix sqlite3_value_text() usage[/-][+][sqlite3] Fix sqlite3_value_text() usage[/+][-][sqlite] Fix sqlite3_value_text() usage[/-][+][sqlite3] Fix sqlite3_value_text() usage[/+][-][sqlite3] Fix sqlite3_value_text() usage[/-][+][sqlite3] Improve sqlite3_value_text() error handling[/+][-][sqlite3] Fix sqlite3_value_text() usage[/-][+][sqlite3] Improve sqlite3_value_text() error handling[/+]erlend-aasland commentedon May 24, 2021
The affected branch is exercised by the following tests:
I've expanded test_aggr_check_param_str and test_param_string to also check empty strings.
pablogsal commentedon Jun 4, 2021
New changeset 006fd86 by Erlend Egeberg Aasland in branch 'main':
bpo-43853: Handle sqlite3_value_text() errors (GH-25422)
006fd86
12 remaining items
serhiy-storchaka commentedon Aug 6, 2021
What about new tests and NEWS update?
erlend-aasland commentedon Aug 23, 2021
See PR 27642 for the expanded tests, and PR 27922 for amending news entries. I didn't combine the two, as I figured you might have more comments on the former PR.
pablogsal commentedon Aug 25, 2021
New changeset 7903a10 by Erlend Egeberg Aasland in branch 'main':
bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922)
7903a10
pablogsal commentedon Aug 25, 2021
New changeset 0ec17a2 by Erlend Egeberg Aasland in branch '3.9':
[3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) (GH-27952)
0ec17a2
pablogsal commentedon Aug 25, 2021
New changeset b34ca7e by Erlend Egeberg Aasland in branch '3.10':
[3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922). (GH-27953)
b34ca7e
erlend-aasland commentedon Aug 26, 2021
Thanks for merging the NEWS amendments, Pablo. We can close this issue after landing PR 27642.
erlend-aasland commentedon Sep 10, 2021
Serhiy, I believe I've addressed your review remarks on PR 27642. Would you mind taking a look at it again if you have time?
gvanrossum commentedon Jan 26, 2022
New changeset 3eb3b4f by Erlend Egeberg Aasland in branch 'main':
bpo-43853: Expand test suite for SQLite UDF's (GH-27642)
3eb3b4f
JelleZijlstra commentedon Feb 21, 2022
New changeset ba457fe by Erlend Egeberg Aasland in branch '3.10':
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030)
ba457fe
miss-islington commentedon Mar 2, 2022
New changeset 3ea2a8f by Erlend Egeberg Aasland in branch '3.9':
[3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) (GH-31586)
3ea2a8f