Repository navigation
Use io.IncrementalNewlineDecoder for doctest newline conversion #87215
Description
| BPO | 43049 |
|---|---|
| Nosy | @pdonis, @merwok, @zware |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-03-02.17:08:19.122>
created_at = <Date 2021-01-28.02:10:04.826>
labels = ['type-feature', 'library', '3.10']
title = 'Use io.IncrementalNewlineDecoder for doctest newline conversion'
updated_at = <Date 2021-03-03.00:45:29.104>
user = 'https://github.com/pdonis'bugs.python.org fields:
activity = <Date 2021-03-03.00:45:29.104>
actor = 'pdonis'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-02.17:08:19.122>
closer = 'zach.ware'
components = ['Library (Lib)']
creation = <Date 2021-01-28.02:10:04.826>
creator = 'pdonis'
dependencies = []
files = []
hgrepos = []
issue_num = 43049
keywords = ['patch']
message_count = 4.0
messages = ['385830', '387939', '387941', '387988']
nosy_count = 3.0
nosy_names = ['pdonis', 'eric.araujo', 'zach.ware']
pr_nums = ['24359']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43049'
versions = ['Python 3.10']
Activity
pdonis commentedon Jan 28, 2021
This is a follow-up to bpo-1812:
https://bugs.python.org/issue1812
It was suggested in the discussion on that issue that the newline conversion in doctest that was corrected in that issue could be done using already defined resources in the io module instead of by a custom function. This issue is to provide an issue number for my pull request on github to do that: the io module provides the IncrementalNewlineDecoder object that does exactly what is needed.
zware commentedon Mar 2, 2021
New changeset b36349a by Peter Donis in branch 'master':
bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion (GH-24359)
b36349a
zware commentedon Mar 2, 2021
Thanks for the patch!
pdonis commentedon Mar 3, 2021
Thanks for merging!