ast.literal_eval doesn't give information about node except the type of it #82577

Activity

1. isidentical commented on Oct 7, 2019

   

   isidentical

   on Oct 7, 2019

   SponsorMemberAuthor

   More actions

   def _convert_num(node):
           if isinstance(node, Constant):
               if type(node.value) in (int, float, complex):
                   return node.value
   >       raise ValueError('malformed node or string: ' + repr(node))
   E       ValueError: malformed node or string: <_ast.Name object at 0x7f0e7ebab320>

   When a malformed node passes into literal_eval, it raises ValueError with repr of node (which is just a memory address and type). I think using dump(node) at there is a better option, like

   node = <_ast.Name object at 0x7fa8279847d0>

       def _convert_num(node):
           if isinstance(node, Constant):
               if type(node.value) in (int, float, complex):
                   return node.value
   >       raise ValueError('malformed node or string: ' + dump(node))
   E       ValueError: malformed node or string: Name(id='a', ctx=Load())
2. isidentical

   added

   3.9 (EOL)end of lifeend of life

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Oct 7, 2019
3. ilevkivskyi commented on Oct 7, 2019

   

   ilevkivskyi

   on Oct 7, 2019

   Member

   More actions

   The downside however is that exception messages can become very long. So I am not sure we should change this.
4. serhiy-storchaka commented on Oct 7, 2019

   

   serhiy-storchaka

   on Oct 7, 2019

   Member

   More actions

   I have same doubts.

   See also bpo-32888.
5. serhiy-storchaka

   closed this as completedon Oct 7, 2019
6. ezio-melotti

   transferred this issue fromon Apr 10, 2022