Repository navigation
Remove urllib.parse._splittype from xmlrpc.client #82219
Description
| BPO | 38038 |
|---|---|
| Nosy | @vstinner, @tiran, @kynan, @serhiy-storchaka, @csabella, @corona10 |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-09-08.09:06:09.936>
created_at = <Date 2019-09-05.14:19:51.845>
labels = ['library', '3.9']
title = 'Remove urllib.parse._splittype from xmlrpc.client'
updated_at = <Date 2021-03-28.09:22:04.006>
user = 'https://github.com/corona10'bugs.python.org fields:
activity = <Date 2021-03-28.09:22:04.006>
actor = 'kynan'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-08.09:06:09.936>
closer = 'corona10'
components = ['Library (Lib)']
creation = <Date 2019-09-05.14:19:51.845>
creator = 'corona10'
dependencies = []
files = []
hgrepos = []
issue_num = 38038
keywords = ['patch']
message_count = 9.0
messages = ['351199', '351318', '351362', '351375', '351388', '351397', '389617', '389618', '389633']
nosy_count = 6.0
nosy_names = ['vstinner', 'christian.heimes', 'kynan', 'serhiy.storchaka', 'cheryl.sabella', 'corona10']
pr_nums = ['15703']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38038'
versions = ['Python 3.9']
Activity
corona10 commentedon Sep 5, 2019
This issue is the same as bpo-22347.
Let's remove the deprecated urllib.parse._splituser and urllib.parse._splittype from xmlrpc.client
[-]Remove urllib.parse._ from xmlrpc.client[/-][+]Remove urllib.parse._splittype from xmlrpc.client[/+]serhiy-storchaka commentedon Sep 8, 2019
New changeset 9c4c459 by Serhiy Storchaka (Dong-hee Na) in branch 'master':
bpo-38038: Remove urllib.parse._splittype from xmlrpc.client. (GH-15703)
9c4c459
vstinner commentedon Sep 9, 2019
splittype() is deprecated, _splittype() is not deprecated.
Should we deprecate _splittype() as well? I don't know the rationale of splittype() deprecation.
corona10 commentedon Sep 9, 2019
@vstinner
Right. splittype() is deprecated.
Nevertheless, the same functionality is still accessible to end users with _splittype (). So I thought we should go in the direction of removing this completely.
From the view of the standard library is used by Python end users as a reference for their own implementation, I suggest removing indirectly usage of deprecated API gradually.
vstinner commentedon Sep 9, 2019
splittype() was deprecated in Python 3.8 by bpo-27485:
commit 0250de4
Author: Cheryl Sabella <[email protected]>
Date: Wed Apr 25 16:51:54 2018 -0700
Dong-hee Na: This issue is about xmlrpc.client. If you consider that it's time to remove deprecated urllib.parse functions, please open a separated issue.
corona10 commentedon Sep 9, 2019
Understood
kynan commentedon Mar 27, 2021
This change caused an (I presume unintended) behavior change that breaks some xmlrpc users: previously, the XLMRPC handler was everything after the host part of the URI (https://github.com/python/cpython/blame/32f825393e5836ab71de843596379fa3f9e23c7a/Lib/xmlrpc/client.py#L1428), but now the query string is *discarded* (https://github.com/python/cpython/blame/63298930fb531ba2bb4f23bc3b915dbf1e17e9e1/Lib/xmlrpc/client.py#L1424).
This is known to break the XMLRPC for DokuWiki (https://www.dokuwiki.org/devel:xmlrpc), which uses query parameters for authentication: kynan/dokuwikixmlrpc#8
tiran commentedon Mar 27, 2021
Please open a new bug and include a reference to this issue.
kynan commentedon Mar 28, 2021
Filed bpo-43645