Repository navigation
Give modulefinder some much-needed updates. #80117
Description
| BPO | 35936 |
|---|---|
| Nosy | @warsaw, @brettcannon, @ncoghlan, @brandtbucher |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-04-07.08:03:40.400>
created_at = <Date 2019-02-08.03:13:18.904>
labels = ['3.8', 'type-feature', 'library']
title = 'Give modulefinder some much-needed updates.'
updated_at = <Date 2019-04-07.08:03:40.399>
user = 'https://github.com/brandtbucher'bugs.python.org fields:
activity = <Date 2019-04-07.08:03:40.399>
actor = 'ncoghlan'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-07.08:03:40.400>
closer = 'ncoghlan'
components = ['Library (Lib)']
creation = <Date 2019-02-08.03:13:18.904>
creator = 'brandtbucher'
dependencies = []
files = []
hgrepos = []
issue_num = 35936
keywords = ['patch', 'patch']
message_count = 4.0
messages = ['335054', '335171', '339560', '339561']
nosy_count = 5.0
nosy_names = ['barry', 'brett.cannon', 'jvr', 'ncoghlan', 'brandtbucher']
pr_nums = ['11787', '11787']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35936'
versions = ['Python 3.8']
Activity
brandtbucher commentedon Feb 8, 2019
I've written a patch here that includes a few useful fixes. Namely:
importlibinstead ofimp, which is deprecated. (25160) As a benefit, frozen built-in modules (zip import, for example), are now correctly reported.With the exception of these bug fixes, I've been very careful to preserve the original behavior, and have not changed any part of the API. This patch also includes 2 new regression tests.
brandtbucher commentedon Feb 10, 2019
Alright, I've gotten all of the tests passing for the new importlib-only implementation. I broke these modifications out into a new private function, _find_module, to make it clear that this fix is a simple drop-in replacement for imp.find_module.
Let me know if there's anything I've missed or could improve. Otherwise, I feel my work here is done!
ncoghlan commentedon Apr 7, 2019
New changeset 9d7b2c0 by Nick Coghlan (Brandt Bucher) in branch 'master':
bpo-35936: Updates to modulefinder (GH-11787)
9d7b2c0
ncoghlan commentedon Apr 7, 2019
Thanks Brandt!
I'll also go back and close bpo-17396, bpo-35376, and bpo-25160