Repository navigation
platform.system_alias(): add macOS support #79697
Description
| BPO | 35516 |
|---|---|
| Nosy | @ronaldoussoren, @vstinner |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-12-18.18:51:54.956>
created_at = <Date 2018-12-17.09:31:27.598>
labels = ['3.8', 'library']
title = 'platform.system_alias(): add macOS support'
updated_at = <Date 2018-12-18.18:51:54.956>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2018-12-18.18:51:54.956>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-18.18:51:54.956>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2018-12-17.09:31:27.598>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 35516
keywords = ['patch']
message_count = 6.0
messages = ['331960', '331961', '331964', '331966', '332047', '332076']
nosy_count = 2.0
nosy_names = ['ronaldoussoren', 'vstinner']
pr_nums = ['11187', '11207']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35516'
versions = ['Python 3.8']
Activity
vstinner commentedon Dec 17, 2018
platform.system_alias() documentation:
Returns
(system, release, version)aliased to common marketing names usedfor some systems. It also does some reordering of the information in some cases
where it would otherwise cause confusion.
IMHO "macOS" and macOS release are more appropriate than darwin and darwin release for platform.system_alias().
I propose to make a similar change in system_alias() than the platform.mac_ver() change made in bpo-35344.
vstinner commentedon Dec 17, 2018
Oops, this issue changed platform.platform() (not platform.mac_ver()).
ronaldoussoren commentedon Dec 17, 2018
The patch does not use the version information passed in to calculate the marketing version. That's a problem when passing in low-level information from a system running a different version of macOS (for example passing in the low-level version information from a macOS 10.8 system while the script is running on a macOS 10.14 system).
vstinner commentedon Dec 17, 2018
Right. The function has a weird API. Maybe the function shouldn't be fixed in this case. If we don't fix it, I would like to at least document why the function doesn't replace Darwin with macOS.
vstinner commentedon Dec 18, 2018
Ronald Oussoren:
I abandonned my PR 11187 and I wrote PR 11207 to add a comment explaining why Darwin is not replaced with macOS.
Well, use platform.platform() or platform.mac_ver() to get the macOS version ;-)
vstinner commentedon Dec 18, 2018
New changeset 60875db by Victor Stinner in branch 'master':
bpo-35516: platform.system_alias() don't replace Darwin (GH-11207)
60875db