Repository navigation
Almost all Windows buildbots are failing to compile #79618
Description
| BPO | 35437 |
|---|---|
| Nosy | @pfmoore, @vstinner, @tjguk, @ned-deily, @zware, @zooba, @pablogsal |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-12-07.15:38:06.622>
created_at = <Date 2018-12-07.09:57:18.306>
labels = ['interpreter-core', '3.7', '3.8', 'OS-windows']
title = 'Almost all Windows buildbots are failing to compile'
updated_at = <Date 2018-12-07.15:38:06.620>
user = 'https://github.com/pablogsal'bugs.python.org fields:
activity = <Date 2018-12-07.15:38:06.620>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-07.15:38:06.622>
closer = 'vstinner'
components = ['Interpreter Core', 'Windows']
creation = <Date 2018-12-07.09:57:18.306>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 35437
keywords = []
message_count = 10.0
messages = ['331283', '331284', '331286', '331289', '331291', '331294', '331299', '331314', '331317', '331327']
nosy_count = 7.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'pablogsal']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35437'
versions = ['Python 3.7', 'Python 3.8']
Activity
pablogsal commentedon Dec 7, 2018
Almost all Windows buildbots are failing to compile Python:
https://buildbot.python.org/all/#/builders/130/builds/525
https://buildbot.python.org/all/#/builders/113/builds/825
https://buildbot.python.org/all/#/builders/121/builds/782
https://buildbot.python.org/all/#/builders/58/builds/1680
https://buildbot.python.org/all/#/builders/17/builds/494
...
I suspect that is due to this commit:
468a15a
and its backports.
pablogsal commentedon Dec 7, 2018
468a15a
pablogsal commentedon Dec 7, 2018
Reverting that commit seem to work:
https://buildbot.python.org/all/#/builders/91/builds/9
pablogsal commentedon Dec 7, 2018
More broken buildbots:
https://buildbot.python.org/all/#/builders/32/builds/1867
vstinner commentedon Dec 7, 2018
vstinner commentedon Dec 7, 2018
vstinner commentedon Dec 7, 2018
See also bpo-35433: "Correctly detect installed SDK versions".
zooba commentedon Dec 7, 2018
Okay, so apparently the buildbots are still building with VS 2015, and not VS 2017.
I'll add a check for the new executable and repush. This was caused solely by the new code and not by any of the changes to existing code.
pablogsal commentedon Dec 7, 2018
@Steve Notice that 468a15a is currently reverted, so you need to push it again if you plan to add something on top of it.
vstinner commentedon Dec 7, 2018
I revert the changes, so buildbots should go back to green. I asked Steve Dower to use a custom build to avoid such hiccup on the next attempt to merge his change.