Repository navigation
asyncio shield: remove inner callback on outer cancellation #79306
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-05-07.19:05:59.639>
created_at = <Date 2018-10-31.15:18:41.298>
labels = ['3.8', 'type-bug', '3.7', 'expert-asyncio']
title = 'asyncio shield: remove inner callback on outer cancellation'
updated_at = <Date 2019-05-07.19:38:02.985>
user = 'https://github.com/mainro'bugs.python.org fields:
activity = <Date 2019-05-07.19:38:02.985>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-07.19:05:59.639>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2018-10-31.15:18:41.298>
creator = 'mainro'
dependencies = []
files = ['47897']
hgrepos = []
issue_num = 35125
keywords = ['patch']
message_count = 3.0
messages = ['328997', '341798', '341807']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'miss-islington', 'mainro']
pr_nums = ['10340', '13167']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35125'
versions = ['Python 3.7', 'Python 3.8']
Activity
MainRo commentedon Oct 31, 2018
When the future returned by shield is cancelled, its completion callback of the inner future is not removed. This makes the callback list of inner inner future grow each time a shield is created.
miss-islington commentedon May 7, 2019
New changeset b35acc5 by Miss Islington (bot) (Romain Picard) in branch 'master':
bpo-35125: remove inner callback on outer cancellation in asyncio shield (GH-10340)
b35acc5
miss-islington commentedon May 7, 2019
New changeset 299f69c by Miss Islington (bot) in branch '3.7':
bpo-35125: remove inner callback on outer cancellation in asyncio shield (GH-10340)
299f69c