Repository navigation
IDLE: rename windows.py as window.py #78087
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2018-06-21.02:05:06.133>
created_at = <Date 2018-06-19.22:52:37.436>
labels = ['easy', '3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: rename windows.py as window.py'
updated_at = <Date 2018-06-21.02:05:06.133>
user = 'https://github.com/terryjreedy'bugs.python.org fields:
activity = <Date 2018-06-21.02:05:06.133>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2018-06-21.02:05:06.133>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-06-19.22:52:37.436>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 33906
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['320003', '320027', '320122', '320129', '320131', '320132']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['7833', '7834', '7835']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33906'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
Activity
terryjreedy commentedon Jun 19, 2018
Change module 'windows' to 'window'::
With all modules at least imported in a test, all imports in modules should be checked, so running test_idle after changing the file name should reveal all imports that need to be changed.
What could have been the 'Window' class is called 'ListedTopLevel'.
[-]IDLE: change windows.py to window.py[/-][+]IDLE: rename windows.py as window.py[/+]terryjreedy commentedon Jun 20, 2018
Also rename idle_test.test_windows as test_window with git mv. Imports:
F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows
F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows
F:\dev\3x\lib\idlelib\macosx.py: 131: from idlelib import windows
terryjreedy commentedon Jun 20, 2018
Marking 2.7 for a search test.
terryjreedy commentedon Jun 21, 2018
New changeset a361e89 by Terry Jan Reedy in branch 'master':
bpo-33906: Rename idlelib.windows as window (bpo-7833)
a361e89
miss-islington commentedon Jun 21, 2018
New changeset f9243a2 by Miss Islington (bot) in branch '3.7':
bpo-33906: Rename idlelib.windows as window (GH-7833)
f9243a2
miss-islington commentedon Jun 21, 2018
New changeset 2839da4 by Miss Islington (bot) in branch '3.6':
bpo-33906: Rename idlelib.windows as window (GH-7833)
2839da4