Repository navigation
IDLE: Minimally test every non-startup module. #78036
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2018-06-21.14:39:00.091>
created_at = <Date 2018-06-14.07:13:13.379>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7']
title = 'IDLE: Minimally test every non-startup module.'
updated_at = <Date 2018-06-21.14:44:40.294>
user = 'https://github.com/terryjreedy'bugs.python.org fields:
activity = <Date 2018-06-21.14:44:40.294>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2018-06-21.14:39:00.091>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-06-14.07:13:13.379>
creator = 'terry.reedy'
dependencies = ['33917']
files = []
hgrepos = []
issue_num = 33855
keywords = ['patch']
message_count = 16.0
messages = ['319501', '319506', '319668', '319683', '319687', '319761', '319871', '319873', '319874', '319925', '319997', '320006', '320008', '320009', '320011', '320102']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'taleinat', 'cheryl.sabella', 'miss-islington']
pr_nums = ['7689', '7731', '7734', '7761', '7774', '7775', '7784', '7805', '7806']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33855'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
Activity
terryjreedy commentedon Jun 14, 2018
For module in idlelib modules:
Create test_module from new template.py.
Add 'module' to docstring and import.
Check other minimal imports.
Create instance of each class, with requires('gui') if needed.
Add initial coverage of this test.
I am also reviewing existing tests.
PR initially adds template, 1 new file, and edits 3 others. Needs blurb. I will add more, but will likely break this up into multiple PRs. This should, of course, been done years ago.
Reviews welcome, non-Windows test would be good. (Tal, what do you have?)
taleinat commentedon Jun 14, 2018
My main laptop is currently Windows 10, I use it for most CPython work.
I also have PCs running OSX, Ubuntu and Windows 7.
Terry, let me know what and when you'd like me to run on which OSs, and I'll get it done :)
terryjreedy commentedon Jun 15, 2018
debugger and debugger_r: tests are subminimal because instantiating classes is not trivial.
dynoption: skipped because I expect it will be replaced and deleted when I review PR to do so.
editor: I discovered, or rediscovered, a new shutdown issue, with EditorWindow. It appeared in the new test_flist also. This time, I discovered how to solve it with tcl after info, thanks to Cheryl using it for test_codecontext.
---
I am going to break this into 3 PRs. The first third is done. Having written this much, I think the new code is very unlikely to break on other OSes, so I don't think special testing is necessary before merging.
Tal, if you have a cpython clone on your OSX machine, it would be nice to have "python -m test.test_idle" (which runs gui tests) run in an updated repository at least once a week if there is anything new.
terryjreedy commentedon Jun 15, 2018
New changeset ee5ef30 by Terry Jan Reedy in branch 'master':
bpo-33855: Minimally test all IDLE modules. (GH-7689)
ee5ef30
miss-islington commentedon Jun 15, 2018
New changeset 5085687 by Miss Islington (bot) in branch '3.7':
bpo-33855: Minimally test all IDLE modules. (GH-7689)
5085687
terryjreedy commentedon Jun 16, 2018
New changeset 833b3d2 by Terry Jan Reedy in branch '3.6':
[3.6] bpo-33855: Minimally test all IDLE modules. (GH-7689) (GH-7734)
833b3d2
terryjreedy commentedon Jun 18, 2018
New changeset ea3dc80 by Terry Jan Reedy in branch 'master':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
ea3dc80
miss-islington commentedon Jun 18, 2018
New changeset 740f1cb by Miss Islington (bot) in branch '3.7':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
740f1cb
miss-islington commentedon Jun 18, 2018
New changeset 684bc3d by Miss Islington (bot) in branch '3.6':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
684bc3d
terryjreedy commentedon Jun 19, 2018
Spinoffs:
change rstrip.RstripExtension to Rstrip
change stackviewer.StackBrowser to accept exception
terryjreedy commentedon Jun 19, 2018
Change windows.py to window.py, in line with change of menu. Should be safer with everything imported.
terryjreedy commentedon Jun 19, 2018
New changeset 4d92158 by Terry Jan Reedy in branch 'master':
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784)
4d92158
miss-islington commentedon Jun 20, 2018
New changeset cbaee6f by Miss Islington (bot) in branch '3.7':
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784)
cbaee6f
miss-islington commentedon Jun 20, 2018
New changeset 90209a1 by Miss Islington (bot) in branch '3.6':
bpo-33855: Still more edits and minimal tests for IDLE (GH-7784)
90209a1
terryjreedy commentedon Jun 20, 2018
Still open for a patch explaining idle_test.template in README.
I opened bpo-33904 for rstrip, bpo-33905 for stackbrowser, bpo-33906 for windows, and bpo-33907 for calltips/CallTip renaming.
terryjreedy commentedon Jun 20, 2018
bpo-33917 is about fixing and documenting template.py.