Repository navigation
Build does not work with closed stdin on NetBSD #77565
Description
| BPO | 33384 |
|---|---|
| Nosy | @vstinner, @0-wiz-0, @xdegaye, @MartinHusemann, @LeoT |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-10-22.23:30:02.974>
created_at = <Date 2018-04-29.10:16:35.561>
labels = ['type-feature', 'build']
title = 'Build does not work with closed stdin on NetBSD'
updated_at = <Date 2019-10-24.10:39:12.784>
user = 'https://github.com/MartinHusemann'bugs.python.org fields:
activity = <Date 2019-10-24.10:39:12.784>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-22.23:30:02.974>
closer = 'vstinner'
components = ['Build']
creation = <Date 2018-04-29.10:16:35.561>
creator = 'MartinHusemann'
dependencies = []
files = ['47604', '47605']
hgrepos = []
issue_num = 33384
keywords = []
message_count = 9.0
messages = ['315886', '316183', '317110', '317114', '317117', '317121', '355179', '355321', '355323']
nosy_count = 5.0
nosy_names = ['vstinner', 'wiz', 'xdegaye', 'MartinHusemann', 'leot']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '30225'
type = 'enhancement'
url = 'https://bugs.python.org/issue33384'
versions = ['Python 3.6']
Activity
MartinHusemann commentedon Apr 29, 2018
When building python extensions in the background w/o stdin (and stderr and stdout redirected to a log file), the invocation of setup.py fails.
Normal build in a shell:
Example from pyexpat:
But if invoked as
and then watching /tmp/log from another session:
Fatal Python error: Py_Initialize: can't initialize sys standard streams
OSError: [Errno 9] Bad file descriptor
Current thread 0x000075b4e4cee800 (most recent call first):
[1] Abort trap (core dumped) /usr/pkg/bin/pyt...
xdegaye commentedon May 4, 2018
I cannot reproduce the problem with Python 3.6.5, building pyephem and with the command:
( sleep 15; python setup.py build ) >foo.log 2>&1
MartinHusemann commentedon May 19, 2018
You need to exit the parent shell, to get the original stdin revoke(2)'d.
That is: the Ctrl-D in the original descritpion is not line noise. Sorry, should have been more explicit (or used "exit" or something instead)
leot commentedon May 19, 2018
A simpler way to reproduce that (probably this problem is not limited to
building but to sys module):
And in `/tmp/log':
leot commentedon May 19, 2018
And here the backtrace of the corresponding core (this is on
NetBSD/amd64 8.99.15 with lang/python36 package of today pkgsrc-current):
Please let me know if any further information is needed and I will try
to help!
Thank you!
leot commentedon May 19, 2018
After testing is_valid_fd() (from Python/pylifecycle.c) separately
(an `is_valid_fd.c' file will be attached to ease reproduction) I think
that also NetBSD is affected by bpo-30225.
Using dup(2) (at is currently done in NetBSD):
Using fstat(2):
The possible attached patch seems to fix the problem reported by Martin.
vstinner commentedon Oct 22, 2019
I'm quite that this issue has been fixed by bpo-30225 which is part Python 3.7.4, Python 3.8.0 and newer. I mark the issue as duplicate of bpo-30225. Please reopen the bug if these versions still fail on NetBSD.
commit 1c4670e
Author: Victor Stinner <[email protected]>
Date: Thu May 4 00:45:56 2017 +0200
[-]Build does not work with closed stdin[/-][+]Build does not work with closed stdin on NetBSD[/+]leot commentedon Oct 24, 2019
Hello Victor,
I can confirm that I can no longer reproduce this problem with Python
3.7.5 on NetBSD and according a double-check to
Python/pylifecycle.c:is_valid_fd() now fstat() is always used on
NetBSD.
Thanks for the update and for looking at it!
vstinner commentedon Oct 24, 2019
Great!