Repository navigation
IDLE: Create new tab for editor options in configdialog #77232
Description
| BPO | 33051 |
|---|---|
| Nosy | @terryjreedy, @roseman, @csabella, @E-Paine |
| PRs | |
| Superseder |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2021-06-10.05:41:08.059>
created_at = <Date 2018-03-11.19:26:19.895>
labels = ['expert-IDLE', 'type-feature', '3.8', '3.9', '3.10']
title = 'IDLE: Create new tab for editor options in configdialog'
updated_at = <Date 2021-06-10.05:41:08.058>
user = 'https://github.com/csabella'bugs.python.org fields:
activity = <Date 2021-06-10.05:41:08.058>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2021-06-10.05:41:08.059>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-03-11.19:26:19.895>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 33051
keywords = ['patch']
message_count = 6.0
messages = ['313618', '316882', '316942', '316947', '375508', '375613']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'markroseman', 'cheryl.sabella', 'epaine']
pr_nums = ['6082']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '40468'
type = 'enhancement'
url = 'https://bugs.python.org/issue33051'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
Activity
csabella commentedon Mar 11, 2018
Split out editor options from general tab in Config Dialog.
terryjreedy commentedon May 17, 2018
I expected that this would be needed eventually. Any particular reason why now?
csabella commentedon May 17, 2018
Yes, I thought it would be good to have this before bpo-33046.
terryjreedy commentedon May 17, 2018
A new option would (maybe) apply to saving the shell also. (Something to discuss there.)
E-Paine commentedon Aug 16, 2020
Thank you Cheryl for linking this issue on bpo-40468 (I didn't find this when researching for existing issues). I have briefly tested the PR and it seems perfect, though seeing
init_validatorsmade me think we should possibly have an ABC for the tab pages. This would be a separate issue, but I think there would be three main advantages:create_page_*would becomecreate_pageand be called by the parent, for example)init_validators(which would preferably be part of the class but I appreciate the need to move it in this PR)TabPageas the ABC would serve as its own exampleBack to this issue, I didn't scrutinise it but the PR looks good and the "result" (user-facing) is exactly as I would propose based on bpo-40468.
csabella commentedon Aug 18, 2020
@epaine, thank you for taking a look at that PR and for your feedback. I agree with you that the changes can still be taken further than we've already done.
init_validatorswas added after the initial refactoring and I'm not sure if we've gone back to it to really use it or any other input validators. There's another bug issue (bpo-31306) that addresses the validation on configdialog, so maybe your ideas can be incorporated with that issue.