Skip to content

Warnings in Modules/_winapi.c #74930

Closed
Closed

Description

@segevfiner
BPO 30745
Nosy @pfmoore, @tjguk, @ned-deily, @zware, @serhiy-storchaka, @zooba, @segevfiner
PRs
  • bpo-30745: Fix compiler warnings introduced in bpo-30730. #2376
  • [3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) #2378
  • [3.5] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) #2379
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2017-06-24.13:26:58.471>
    created_at = <Date 2017-06-24.10:13:59.533>
    labels = ['build', '3.7', 'OS-windows']
    title = 'Warnings in Modules/_winapi.c'
    updated_at = <Date 2017-07-08.04:51:39.063>
    user = 'https://github.com/segevfiner'

    bugs.python.org fields:

    activity = <Date 2017-07-08.04:51:39.063>
    actor = 'ned.deily'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2017-06-24.13:26:58.471>
    closer = 'serhiy.storchaka'
    components = ['Windows']
    creation = <Date 2017-06-24.10:13:59.533>
    creator = 'Segev Finer'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30745
    keywords = []
    message_count = 7.0
    messages = ['296761', '296763', '296764', '296766', '296768', '296771', '297930']
    nosy_count = 7.0
    nosy_names = ['paul.moore', 'tim.golden', 'ned.deily', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'Segev Finer']
    pr_nums = ['2376', '2378', '2379']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue30745'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    Activity

    1. segevfiner commented on Jun 24, 2017

      segevfinermannequin
      MannequinAuthor

      ..\Modules\_winapi.c(886): warning C4090: 'function': different 'const' qualifiers
      ..\Modules\_winapi.c(848): warning C4101: 'wenvironment_size': unreferenced local variable

      Added in d174d24

    2. serhiy-storchaka commented on Jun 24, 2017

      @serhiy-storchaka
      Member

      Thank you for noticing this Segev. I hope the following PR fixes warnings.

    3. segevfiner commented on Jun 24, 2017

      segevfinermannequin
      MannequinAuthor

      I tried the PR locally and I didn't get the warnings. :)

    4. serhiy-storchaka commented on Jun 24, 2017

      @serhiy-storchaka
      Member

      New changeset 0ee32c1 by Serhiy Storchaka in branch 'master':
      bpo-30745: Fix compiler warnings introduced in bpo-30730. (bpo-2376)
      0ee32c1

    5. serhiy-storchaka commented on Jun 24, 2017

      @serhiy-storchaka
      Member

      New changeset 0e1f9e8 by Serhiy Storchaka in branch '3.6':
      [3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (bpo-2378)
      0e1f9e8

    6. serhiy-storchaka commented on Jun 24, 2017

      @serhiy-storchaka
      Member

      New changeset e0d446e by Serhiy Storchaka in branch '3.5':
      [3.5] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (bpo-2379)
      e0d446e

    7. ned-deily commented on Jul 8, 2017

      @ned-deily
      Member

      New changeset d1d6501 by Ned Deily (Serhiy Storchaka) in branch '3.6':
      [3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (bpo-2378)
      d1d6501

    8. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions