Skip to content

Simplify argument parsing in sorted() and list.sort() #73517

Closed

Description

@serhiy-storchaka
BPO 29331
Nosy @rhettinger, @vstinner, @serhiy-storchaka, @MojoVampire
Files
  • sort-arg-parse.patch
  • sort-arg-parse-2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-01-21.21:06:23.594>
    created_at = <Date 2017-01-20.06:59:39.688>
    labels = ['interpreter-core', 'type-feature', '3.7']
    title = 'Simplify argument parsing in sorted() and list.sort()'
    updated_at = <Date 2017-01-21.21:06:23.593>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-01-21.21:06:23.593>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-01-21.21:06:23.594>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2017-01-20.06:59:39.688>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['46351', '46353']
    hgrepos = []
    issue_num = 29331
    keywords = ['patch']
    message_count = 4.0
    messages = ['285887', '285901', '285964', '285965']
    nosy_count = 5.0
    nosy_names = ['rhettinger', 'vstinner', 'python-dev', 'serhiy.storchaka', 'josh.r']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29331'
    versions = ['Python 3.7']

    Activity

    1. serhiy-storchaka commented on Jan 20, 2017

      @serhiy-storchaka
      MemberAuthor

      Proposed patch simplifies argument parsing in sorted() and list.sort().

      list.sort() now uses the support of keyword-only parameters in PyArg_ParseTupleAndKeywords().

      Keyword arguments now are passed as is to list.sorted() in sorted().

    2. vstinner commented on Jan 20, 2017

      @vstinner
      Member

      sort-arg-parse-2.patch now LGTM with the comment, thanks :-)

    3. python-dev commented on Jan 21, 2017

      python-devmannequin
      Mannequin

      New changeset 69bd5c497a82 by Serhiy Storchaka in branch 'default':
      Issue bpo-29331: Simplified argument parsing in sorted() and list.sort().
      https://hg.python.org/cpython/rev/69bd5c497a82

    4. serhiy-storchaka commented on Jan 21, 2017

      @serhiy-storchaka
      MemberAuthor

      Thanks Victor.

    5. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.7 (EOL)end of lifeinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions